From: Aleksey Senin <alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Moni Shoua <monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>,
Nir Muchtar <nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Subject: [PATCH v3 3/4] Add RAW_PACKET to verbs attach/detach multicast
Date: Mon, 6 Dec 2010 09:37:19 +0200 [thread overview]
Message-ID: <4CFC92AF.8070009@voltaire.com> (raw)
In-Reply-To: <4CFC926B.8060305-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Sanity check - validate that the subnet_prefix bits set to zero'es.
Signed-off-by: Aleksey Senin <alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
drivers/infiniband/core/verbs.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 611c13c..9e4998c 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -904,7 +904,10 @@ int ib_attach_mcast(struct ib_qp *qp, union ib_gid *gid, u16 lid)
{
if (!qp->device->attach_mcast)
return -ENOSYS;
- if (gid->raw[0] != 0xff || qp->qp_type != IB_QPT_UD)
+ if (qp->qp_type == IB_QPT_RAW_PACKET) {
+ if (gid->global.subnet_prefix & cpu_to_be64(~1ULL))
+ return -EINVAL;
+ } else if (gid->raw[0] != 0xff || qp->qp_type != IB_QPT_UD)
return -EINVAL;
return qp->device->attach_mcast(qp, gid, lid);
@@ -915,7 +918,10 @@ int ib_detach_mcast(struct ib_qp *qp, union ib_gid *gid, u16 lid)
{
if (!qp->device->detach_mcast)
return -ENOSYS;
- if (gid->raw[0] != 0xff || qp->qp_type != IB_QPT_UD)
+ if (qp->qp_type == IB_QPT_RAW_PACKET) {
+ if (gid->global.subnet_prefix & cpu_to_be64(~1ULL))
+ return -EINVAL;
+ } else if (gid->raw[0] != 0xff || qp->qp_type != IB_QPT_UD)
return -EINVAL;
return qp->device->detach_mcast(qp, gid, lid);
--
1.6.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-06 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 7:32 [PATCH v3 0/4] New RAW_PACKET QP type Aleksey Senin
[not found] ` <4CFC918D.1090708-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-12-06 7:34 ` [PATCH v3 1/4] RAW_PACKET QP type definition Aleksey Senin
[not found] ` <4CFC921D.3000907-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-12-06 7:36 ` [PATCH v3 2/4] RAW_PACKET QP capabilities check Aleksey Senin
[not found] ` <4CFC926B.8060305-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-12-06 7:37 ` Aleksey Senin [this message]
[not found] ` <4CFC92AF.8070009-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-12-06 7:38 ` [PATCH v3 4/4] mlx4: RAW PACKET QP support Aleksey Senin
2011-03-08 21:13 ` [PATCH v3 0/4] New RAW_PACKET QP type Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFC92AF.8070009@voltaire.com \
--to=alekseys-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org \
--cc=nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).