Re: [PATCH] replace (long*)(long) casting with transportable data type (uintptr_t)

[Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 12/6/2010 6:55 PM, Stan C. Smith wrote:
>
> Hello,
>    Your suggestion of removing extra casts does operate correctly under windows x64/x86 variants.
> Windows compilers have improved.
>
> thanks,
>
> Stan.
>
> Signed-off-by: stan smith<stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> diff --git a/opensm/libvendor/osm_vendor_ibumad_sa.c b/opensm/libvendor/osm_vendor_ibumad_sa.c
> index 1fdcc47..63728ad 100644
> --- a/opensm/libvendor/osm_vendor_ibumad_sa.c
> +++ b/opensm/libvendor/osm_vendor_ibumad_sa.c
> @@ -85,8 +85,7 @@ __osmv_sa_mad_rcv_cb(IN osm_madw_t * p_madw,
>
>   	/* obtain the sent context since we store it during send in the ni_ctx */
>   	p_query_req_copy =
> -	    (osmv_query_req_t *) (long *)(long)(p_req_madw->context.ni_context.
> -						node_guid);
> +	    (osmv_query_req_t *) p_req_madw->context.ni_context.node_guid;
>
>   	/* provide the context of the original request in the result */
>   	query_res.query_context = p_query_req_copy->query_context;
> @@ -181,8 +180,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw)
>
>   	/* Obtain the sent context etc */
>   	p_query_req_copy =
> -	    (osmv_query_req_t *) (long *)(long)(p_madw->context.ni_context.
> -						node_guid);
> +	    (osmv_query_req_t *) p_madw->context.ni_context.node_guid;

On an x86 Linux machine, the above 2 instances changed now complain 
about warning: cast to pointer from integer of different size

so should those be cast to (osmv_query_req_t *) (long) or 
(osmv_query_req_t *) (uintptr_t) or something else ?

-- Hal
	
>
>   	/* provide the context of the original request in the result */
>   	query_res.query_context = p_query_req_copy->query_context;
> @@ -433,7 +431,7 @@ __osmv_send_sa_req(IN osmv_sa_bind_info_t * p_bind,
>   	}
>   	*p_query_req_copy = *p_query_req;
>   	p_madw->context.ni_context.node_guid =
> -	    (ib_net64_t) (long)p_query_req_copy;
> +	    (ib_net64_t) (uintptr_t)p_query_req_copy;
>
>   	/* we can support async as well as sync calls */
>   	sync = ((p_query_req->flags&  OSM_SA_FLAGS_SYNC) == OSM_SA_FLAGS_SYNC);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html