Re: [PATCH V3 1/6] IB Netlink Infrastructure

Nir Muchtar
2010-12-19T14:34:07Z

On Tue, 2010-12-14 at 11:34 -0700, Jason Gunthorpe wrote:
> On Mon, Dec 13, 2010 at 06:22:45PM +0200, Nir Muchtar wrote:
>
> > +int ibnl_add_client(int index, int nops,
> > + int (*cb_table[])(struct sk_buff *skb,
> > + struct netlink_callback *nlcb))
>
> If you are going this way, then I think it would be better to have
> netlink_dump_start be optional - not many calls need it.
>

Yes, we may need such functionality in the future, but I'm reluctant to
add APIs that are not currently used, So I think we should wait until we
actually need this addition. It will be very straightforward to add once
we decide to. Don't you agree?