From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] osmtest/osmt_multicast.c: In some multicast flows, insufficient comps should be a warning
Date: Mon, 04 Apr 2011 15:25:02 -0400 [thread overview]
Message-ID: <4D9A1B0E.9010904@dev.mellanox.co.il> (raw)
rather than error (it's preferred but not required)
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/osmtest/osmt_multicast.c b/osmtest/osmt_multicast.c
index b4e2a54..52577bc 100644
--- a/osmtest/osmt_multicast.c
+++ b/osmtest/osmt_multicast.c
@@ -1,6 +1,6 @@
/*
* Copyright (c) 2006-2009 Voltaire, Inc. All rights reserved.
- * Copyright (c) 2002-2005,2008 Mellanox Technologies LTD. All rights
reserved.
+ * Copyright (c) 2002-2011 Mellanox Technologies LTD. All rights reserved.
* Copyright (c) 1996-2003 Intel Corporation. All rights reserved.
* Copyright (c) 2010 HNR Consulting. All rights reserved.
*
@@ -738,13 +738,15 @@ ib_api_status_t osmt_run_mcast_flow(IN osmtest_t *
const p_osmt)
sa_mad);
OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, EXPECTING_ERRORS_END "\n");
- if (status != IB_REMOTE_ERROR ||
- ((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
- IB_SA_MAD_STATUS_INSUF_COMPS) {
- OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02EE: "
- "Expected REMOTE ERROR IB_SA_MAD_STATUS_INSUF_COMPS got:%s/%s\n",
- ib_get_err_str(status),
+ if (((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
+ IB_SA_MAD_STATUS_INSUF_COMPS)
+ OSM_LOG(&p_osmt->log, OSM_LOG_INFO,
+ "Expected IB_SA_MAD_STATUS_INSUF_COMPS got:%s\n",
ib_get_mad_status_str((ib_mad_t *) sa_mad));
+ if (status != IB_REMOTE_ERROR) {
+ OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02EE: "
+ "Expected REMOTE ERROR got:%s\n",
+ ib_get_err_str(status));
status = IB_ERROR;
goto Exit;
}
@@ -769,13 +771,15 @@ ib_api_status_t osmt_run_mcast_flow(IN osmtest_t *
const p_osmt)
sa_mad);
OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, EXPECTING_ERRORS_END "\n");
- if (status != IB_REMOTE_ERROR ||
- ((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
- IB_SA_MAD_STATUS_INSUF_COMPS) {
- OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02ED: "
- "Expected REMOTE ERROR IB_SA_MAD_STATUS_INSUF_COMPS got:%s/%s\n",
- ib_get_err_str(status),
+ if (((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
+ IB_SA_MAD_STATUS_INSUF_COMPS)
+ OSM_LOG(&p_osmt->log, OSM_LOG_INFO,
+ "Expected IB_SA_MAD_STATUS_INSUF_COMPS got:%s\n",
ib_get_mad_status_str((ib_mad_t *) sa_mad));
+ if (status != IB_REMOTE_ERROR) {
+ OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02ED: "
+ "Expected REMOTE ERROR got:%s\n",
+ ib_get_err_str(status));
status = IB_ERROR;
goto Exit;
}
@@ -1073,6 +1077,7 @@ ib_api_status_t osmt_run_mcast_flow(IN osmtest_t *
const p_osmt)
/* no MGID */
memset(&mc_req_rec.mgid, 0, sizeof(ib_gid_t));
/* Request Join */
+ mc_req_rec.pkey = IB_DEFAULT_PKEY;
ib_member_set_join_state(&mc_req_rec, IB_MC_REC_STATE_FULL_MEMBER);
comp_mask =
@@ -1087,13 +1092,15 @@ ib_api_status_t osmt_run_mcast_flow(IN osmtest_t
* const p_osmt)
sa_mad);
OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, EXPECTING_ERRORS_END "\n");
- if (status != IB_REMOTE_ERROR ||
- ((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
- IB_SA_MAD_STATUS_INSUF_COMPS) {
- OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02A8: "
- "Expected REMOTE ERROR IB_SA_MAD_STATUS_INSUF_COMPS got:%s/%s\n",
- ib_get_err_str(status),
+ if (((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
+ IB_SA_MAD_STATUS_INSUF_COMPS)
+ OSM_LOG(&p_osmt->log, OSM_LOG_INFO,
+ "Expected IB_SA_MAD_STATUS_INSUF_COMPS got:%s\n",
ib_get_mad_status_str((ib_mad_t *) sa_mad));
+ if (status != IB_REMOTE_ERROR) {
+ OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02A8: "
+ "Expected REMOTE ERROR got:%s\n",
+ ib_get_err_str(status));
status = IB_ERROR;
goto Exit;
}
@@ -1165,6 +1172,7 @@ ib_api_status_t osmt_run_mcast_flow(IN osmtest_t *
const p_osmt)
/* no MGID */
memset(&mc_req_rec.mgid, 0, sizeof(ib_gid_t));
/* Request Join */
+ mc_req_rec.pkey = IB_DEFAULT_PKEY;
ib_member_set_join_state(&mc_req_rec, IB_MC_REC_STATE_FULL_MEMBER);
comp_mask =
@@ -1180,13 +1188,15 @@ ib_api_status_t osmt_run_mcast_flow(IN osmtest_t
* const p_osmt)
sa_mad);
OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, EXPECTING_ERRORS_END "\n");
- if (status != IB_REMOTE_ERROR ||
- ((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
- IB_SA_MAD_STATUS_INSUF_COMPS) {
- OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02A6: "
- "Expected REMOTE ERROR IB_SA_MAD_STATUS_INSUF_COMPS got:%s/%s\n",
- ib_get_err_str(status),
+ if (((ib_net16_t) (sa_mad->status & IB_SMP_STATUS_MASK)) !=
+ IB_SA_MAD_STATUS_INSUF_COMPS)
+ OSM_LOG(&p_osmt->log, OSM_LOG_INFO,
+ "Expected IB_SA_MAD_STATUS_INSUF_COMPS got:%s\n",
ib_get_mad_status_str((ib_mad_t *) sa_mad));
+ if (status != IB_REMOTE_ERROR) {
+ OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 02A6: "
+ "Expected REMOTE ERROR got:%s\n",
+ ib_get_err_str(status));
status = IB_ERROR;
goto Exit;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2011-04-04 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 19:25 Hal Rosenstock [this message]
[not found] ` <4D9A1B0E.9010904-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-04-05 15:56 ` [PATCH] osmtest/osmt_multicast.c: In some multicast flows, insufficient comps should be a warning Alex Netes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9A1B0E.9010904@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox