From: Steve Wise <swise@opengridcomputing.com>
To: roel <roel.kluin@gmail.com>
Cc: Steve Wise <swise@chelsio.com>,
linux-rdma@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/cxgb4: missing parentheses
Date: Sun, 10 Apr 2011 15:12:58 -0500 [thread overview]
Message-ID: <4DA20F4A.3040205@opengridcomputing.com> (raw)
In-Reply-To: <4DA20964.6050806@gmail.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
On 4/10/2011 2:47 PM, roel wrote:
> Parens are missing: '|' has a higher presedence than '?'.
>
> Signed-off-by: Roel Kluin<roel.kluin@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/qp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
> index 70a5a3c..80cab20 100644
> --- a/drivers/infiniband/hw/cxgb4/qp.c
> +++ b/drivers/infiniband/hw/cxgb4/qp.c
> @@ -214,7 +214,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq,
> V_FW_RI_RES_WR_HOSTFCMODE(0) | /* no host cidx updates */
> V_FW_RI_RES_WR_CPRIO(0) | /* don't keep in chip cache */
> V_FW_RI_RES_WR_PCIECHN(0) | /* set by uP at ri_init time */
> - t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0 |
> + (t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0) |
> V_FW_RI_RES_WR_IQID(scq->cqid));
> res->u.sqrq.dcaen_to_eqsize = cpu_to_be32(
> V_FW_RI_RES_WR_DCAEN(0) |
next prev parent reply other threads:[~2011-04-10 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 19:47 [PATCH] RDMA/cxgb4: missing parentheses roel
2011-04-10 20:12 ` Steve Wise [this message]
[not found] ` <4DA20F4A.3040205-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2011-04-11 17:54 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA20F4A.3040205@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=roel.kluin@gmail.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox