Re: [PATCH 1/2] opensm/osm_port: Add infrastructure for alias GUID support

Alex Netes
2011-04-20T12:08:54Z

Hi Hal,

On 11:00 Mon 11 Apr , Hal Rosenstock wrote:
>
> alias GUIDs are those indicated in SM GUIDInfo attribute
> (other than index 0) and are created/removed via SA Set/Delete
> of GUIDInfoRecord per IBTA MgtWG errata RefIDs 4704-4706.
>
> Up to now, this attribute was unneeded by the SM as only base port
> GUIDs were supported (and are available from the SM NodeInfo attribute).
>
> In order to support alias GUIDs, a new alias GUID table is to be added
> indexed by alias GUID, each containing a pointer to the base port. The
> routines for creating and removing alias GUID table entries are added
> by this patch. Also, a pointer to the alias port GUIDs provided by the
> SM GUIDInfo attribute is added to the osm_physp_t structure.
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> diff --git a/include/opensm/osm_port.h b/include/opensm/osm_port.h
> index ee9feec..3433e31 100644
> --- a/include/opensm/osm_port.h
> +++ b/include/opensm/osm_port.h
> @@ -1,6 +1,6 @@
> /*
> * Copyright (c) 2004-2009 Voltaire, Inc. All rights reserved.
> - * Copyright (c) 2002-2007 Mellanox Technologies LTD. All rights reserved.
> + * Copyright (c) 2002-2010 Mellanox Technologies LTD. All rights reserved.
> * Copyright (c) 1996-2003 Intel Corporation. All rights reserved.
> *
> * This software is available to you under a choice of one of two
> @@ -105,6 +105,7 @@ struct osm_mgrp;
> typedef struct osm_physp {
> ib_port_info_t port_info;
> ib_net64_t port_guid;
> + ib_net64_t (*p_guids)[];

Can we use only one array for port guids? I guess port_guid would be always
the first element of p_guids[].

-- Alex