public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
Subject: Re: [PATCH 1/2] RDMA/cxgb4: Reset wait condition atomically.
Date: Fri, 29 Apr 2011 11:22:38 -0500	[thread overview]
Message-ID: <4DBAE5CE.1080702@opengridcomputing.com> (raw)
In-Reply-To: <20110422175607.8004.14295.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>


On 04/22/2011 12:56 PM, Steve Wise wrote:
> The driver was never really waiting for RDMA_WR/FINI completions because
> the condition variable used to determine if the completion happened was
> never reset, and this condition variable is reused for both connection
> setup and teardown.  This causes various driver crashes under heavy
> loads due to releasing resources too early.
>
> The fix is to use atomic bits to correctly reset the condition immediately
> after the completion is detected.
>
> Signed-off-by: Steve Wise<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

Hey Roland, are these 2 patches ok to merge?

Thanks,

Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-04-29 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 17:56 [PATCH 1/2] RDMA/cxgb4: Reset wait condition atomically Steve Wise
     [not found] ` <20110422175607.8004.14295.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2011-04-22 17:56   ` [PATCH 2/2] RDMA/cxgb4: EEH errors can hang the driver Steve Wise
2011-04-29 16:22   ` Steve Wise [this message]
     [not found]     ` <4DBAE5CE.1080702-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2011-04-29 16:24       ` [PATCH 1/2] RDMA/cxgb4: Reset wait condition atomically Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBAE5CE.1080702@opengridcomputing.com \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox