[PATCH] rdma cm typo + bug report

[PATCH] rdma cm typo + bug report

[frank zago]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

Hi Sean,

Here's a patch for a typo.

I also think there's a bug with ucma_create_cqs()/ucma_destroy_cqs() because ucma_destroy_cqs unconditionally destroys the CQs, even if they were given by the application. librdmacm should only destroy the CQs it created.

Regards,
  Frank.

[-- Attachment #2: rdmacm-typo.diff --]
[-- Type: text/x-diff, Size: 332 bytes --]

diff --git a/examples/rdma_server.c b/examples/rdma_server.c
index 2831d0c..5b9e16d 100644
--- a/examples/rdma_server.c
+++ b/examples/rdma_server.c
@@ -97,7 +97,7 @@ static int run(void)
 
 	ret = rdma_accept(id, NULL);
 	if (ret) {
-		printf("rdma_connect %d\n", errno);
+		printf("rdma_accept %d\n", errno);
 		return ret;
 	}
 

RE: [PATCH] rdma cm typo + bug report

[Hefty, Sean]

> Here's a patch for a typo.

Thanks - I added a patch for this.
 
> I also think there's a bug with ucma_create_cqs()/ucma_destroy_cqs()
> because ucma_destroy_cqs unconditionally destroys the CQs, even if they
> were given by the application. librdmacm should only destroy the CQs it
> created.

I think we're okay here.  ucma_create_cqs() only allocates a CQ if the user specified a CQ of NULL as part of the QP attributes.  It stores the allocated CQ in id->send/recv_cq.  ucma_destroy_cqs() checks for id->send/recv_cq and destroys them.

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma cm typo + bug report

[frank zago]

On 05/09/2011 05:34 PM, Hefty, Sean wrote:

>> I also think there's a bug with ucma_create_cqs()/ucma_destroy_cqs()
>> because ucma_destroy_cqs unconditionally destroys the CQs, even if they
>> were given by the application. librdmacm should only destroy the CQs it
>> created.
> 
> I think we're okay here.  ucma_create_cqs() only allocates a CQ if the user specified a CQ of NULL as part of the QP attributes.  It stores the allocated CQ in id->send/recv_cq.  ucma_destroy_cqs() checks for id->send/recv_cq and destroys them.

Indeed. Sorry.

Frank.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html