Re: [PATCH] RDMA/cxgb4: don't declare wr_wait objects on the stack.

Roland Dreier
2011-05-16T15:53:03Z

On Mon, May 16, 2011 at 8:18 AM, Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+v7I7tHvgBF7@public.gmane.orgm> wrote:
> Roland, I need to recall this patch.  It appears to have some problem.

Good thing I didn't apply it yet.

I did think it should be possible to declare wait objects on the stack... the
origin of completions was to handle exactly that issue; the older semaphore
structure was vulnerable to the wakeup after free, but completions handle
that. But I didn't look at the cxgb4 code at all...

- R.