From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 14/13] opensm/osm_sa_guidinfo_record.c: Fix locking
Date: Sat, 21 May 2011 10:56:26 -0400 [thread overview]
Message-ID: <4DD7D29A.3030206@dev.mellanox.co.il> (raw)
Fix locking around set_guidinfo/del_guidinfo
Found and fixed by: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/opensm/osm_sa_guidinfo_record.c b/opensm/osm_sa_guidinfo_record.c
index c792943..a1bb166 100644
--- a/opensm/osm_sa_guidinfo_record.c
+++ b/opensm/osm_sa_guidinfo_record.c
@@ -737,10 +737,12 @@ void osm_gir_rcv_process(IN void *ctx, IN void *data)
if (!osm_physp_share_pkey(sa->p_log, p_req_physp,
p_port->p_physp))
goto Exit;
+ CL_PLOCK_EXCL_ACQUIRE(sa->p_lock);
if (p_rcvd_mad->method == IB_MAD_METHOD_SET)
set_guidinfo(sa, p_madw, p_port, p_rcvd_rec->block_num);
else
del_guidinfo(sa, p_madw, p_port, p_rcvd_rec->block_num);
+ CL_PLOCK_RELEASE(sa->p_lock);
break;
default:
OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 5105: "
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2011-05-21 14:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD7D29A.3030206@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox