From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] opensm/osm_ucast_mgr.c: Fix some issues found by Coverity
Date: Tue, 31 May 2011 07:30:13 -0400 [thread overview]
Message-ID: <4DE4D145.8060104@dev.mellanox.co.il> (raw)
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/opensm/osm_ucast_mgr.c b/opensm/osm_ucast_mgr.c
index 211d6e0..600bb10 100644
--- a/opensm/osm_ucast_mgr.c
+++ b/opensm/osm_ucast_mgr.c
@@ -529,6 +529,7 @@ static int set_dimn_ports(void *ctx, uint64_t guid, char *p)
if (!ports) {
OSM_LOG(&p_subn->p_osm->log, OSM_LOG_ERROR,
"ERR 3A08: cannot allocate memory for ports\n");
+ free(dimn_ports);
return -1;
}
memset(ports, 0, words*sizeof(*ports));
@@ -794,6 +795,8 @@ static void add_sw_endports_to_order_list(osm_switch_t * sw,
port = osm_get_port_by_guid(m->p_subn,
p->p_remote_physp->
port_guid);
+ if (!port)
+ continue;
cl_qlist_insert_tail(&m->port_order_list,
&port->list_item);
port->flag = 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2011-05-31 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 11:30 Hal Rosenstock [this message]
[not found] ` <4DE4D145.8060104-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-06-01 16:24 ` [PATCH] opensm/osm_ucast_mgr.c: Fix some issues found by Coverity Alex Netes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE4D145.8060104@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox