* [PATCH] infiniband-diags/ibportstate.c: Fix sizeof
@ 2011-06-08 12:57 Hal Rosenstock
[not found] ` <4DEF71D3.30705-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2011-06-08 12:57 UTC (permalink / raw)
To: Ira Weiny; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
It shouldn't be sizeof the pointer but this doesn't affect execution
since this parameter is not used by mad_dump_portstates
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/ibportstate.c b/src/ibportstate.c
index d2ee58b..1f0f42e 100644
--- a/src/ibportstate.c
+++ b/src/ibportstate.c
@@ -126,7 +126,7 @@ static void show_port_info(ib_portid_t * dest, uint8_t * data, int portnum)
char buf[2048];
char val[64];
- mad_dump_portstates(buf, sizeof buf, data, sizeof data);
+ mad_dump_portstates(buf, sizeof buf, data, sizeof *data);
mad_decode_field(data, IB_PORT_LID_F, val);
mad_dump_field(IB_PORT_LID_F, buf + strlen(buf),
sizeof buf - strlen(buf), val);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] infiniband-diags/ibportstate.c: Fix sizeof
[not found] ` <4DEF71D3.30705-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2011-06-10 18:43 ` Ira Weiny
0 siblings, 0 replies; 2+ messages in thread
From: Ira Weiny @ 2011-06-10 18:43 UTC (permalink / raw)
To: Hal Rosenstock; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Wed, 8 Jun 2011 05:57:55 -0700
Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
>
> It shouldn't be sizeof the pointer but this doesn't affect execution
> since this parameter is not used by mad_dump_portstates
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks applied,
Ira
> ---
> diff --git a/src/ibportstate.c b/src/ibportstate.c
> index d2ee58b..1f0f42e 100644
> --- a/src/ibportstate.c
> +++ b/src/ibportstate.c
> @@ -126,7 +126,7 @@ static void show_port_info(ib_portid_t * dest, uint8_t * data, int portnum)
> char buf[2048];
> char val[64];
>
> - mad_dump_portstates(buf, sizeof buf, data, sizeof data);
> + mad_dump_portstates(buf, sizeof buf, data, sizeof *data);
> mad_decode_field(data, IB_PORT_LID_F, val);
> mad_dump_field(IB_PORT_LID_F, buf + strlen(buf),
> sizeof buf - strlen(buf), val);
--
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-10 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-08 12:57 [PATCH] infiniband-diags/ibportstate.c: Fix sizeof Hal Rosenstock
[not found] ` <4DEF71D3.30705-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-06-10 18:43 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox