Re: [PATCH] opensm: Add support for partition enforcement types

Hal Rosenstock
2011-07-11T12:08:54Z

Hi Alex,

On 7/10/2011 7:26 AM, Alex Netes wrote:
> Hi Hal,
>
> On 14:52 Tue 05 Jul , Hal Rosenstock wrote:
>>
>> Partition enforcement types are in, out, and both.
>> Prior to this support, both was being used so that is the default.
>>
>> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> ---
>
> Now we end up with two parameters for same functionality:
> no_part_enforce - you define whether the enforcement is disabled or enabled.
> part_enforcement_type - you define enforcement type: in/out/both.
>
> When no_part_enforce is disabled, part_enforcement_type has no meaning.

Yes.

> Don't you find it simpler if we had only one option for partition enforcement
> with 4 options: disabled/in/out/both(default)?

I didn't want to break backward compatibility with existing command line
or option file.

If we were starting from scratch, it would be one option.

-- Hal

> -- Alex