From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>,
Liran Liss <liranl-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] libibmad: Support for Mellanox vendor specific ExtendedPortInfo SM class MAD
Date: Thu, 14 Jul 2011 14:48:58 -0400 [thread overview]
Message-ID: <4E1F3A1A.2020103@dev.mellanox.co.il> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237302E197-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 7/14/2011 2:34 PM, Hefty, Sean wrote:
>> - IB_ATTR_LAST
>> + IB_ATTR_LAST,
>> +
>> + IB_ATTR_MLNX_EXT_PORT_INFO = 0xff90,
>> };
>
> Seems kind of odd to have something come after 'last'..
I'm not sure why IB_ATTR_LAST is even there (similarly for
IB_SA_ATTR_LAST); maybe a historical vestige at this point but due to
backward compatibility (who knows if it's used) should remain.
It's a poor name given vendor SM attribute IDs.
I didn't think it was safe to have IB_ATTR_LAST increase from 0x21 to
0xff91 because of this so I thought it best to add it as I did and treat
this new attribute ID as an exception if needed which it isn't currently.
-- Hal
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-14 18:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 18:23 [PATCH] libibmad: Support for Mellanox vendor specific ExtendedPortInfo SM class MAD Hal Rosenstock
[not found] ` <4E1F3419.3010508-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-07-14 18:34 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237302E197-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-07-14 18:48 ` Hal Rosenstock [this message]
2011-08-03 19:51 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1F3A1A.2020103@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liranl-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=weiny2-i2BcT+NCU+M@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox