Re: ib-diags and ib_get_err_str

[Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 8/5/2011 8:17 PM, Ira Weiny wrote:
> On Fri, 5 Aug 2011 16:57:02 -0700
> "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> 
>>> This is picked up by libosmcomp.so
>>  
>> Is this a new library built as part of opensm?
> 
> opensm-libs is the specific package.
> 
> I don't think it is that new.

It's not new. It's built as part of the OpenSM. Mainly osm_helper and
maybe a few other things (common code for perhaps more than OpenSM).

> 
>>
>> I'm trying to update the windows build and haven't followed the changes recently.  Why are the diags dependent on error types outside of what ibmad reports?
> 
> I am not quite sure at the moment.  This function has been used in saquery since the beginning of the git tree.

saquery may have been added some time back in the svn days. AFAIR it was
the first diag which had this dependency. It was decided to use some
code which could be common in SA and SA client which is what saquery is.

  Also there are other needs for libosmcomp (cl_qmap and node name map
support for example.)  Although I would like to see the dependency (on
opensm-libs) removed it will take more than that function.

I don't know how far this dependency goes (did it creep into any other
diags) ? It could be eliminated (perhaps cleaner that way) at the "cost"
of some logically duplicated code.

-- Hal


> Ira
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html