[PATCH -next] infiniband: fix ipath_chip_init.c build errors

[PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Randy Dunlap]

From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>

Add <linux/stat.h> to fix build errors:

drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: 'S_IRUGO' undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: bit-field '<anonymous>' width not an integer constant
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: 'S_IWUSR' undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: bit-field '<anonymous>' width not an integer constant

Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Cc:	Mike Marciniszyn <infinipath-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc:	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
 drivers/infiniband/hw/ipath/ipath_init_chip.c |    1 +
 1 file changed, 1 insertion(+)

--- next-2011-1007.orig/drivers/infiniband/hw/ipath/ipath_init_chip.c
+++ next-2011-1007/drivers/infiniband/hw/ipath/ipath_init_chip.c
@@ -35,6 +35,7 @@
 #include <linux/netdevice.h>
 #include <linux/moduleparam.h>
 #include <linux/slab.h>
+#include <linux/stat.h>
 #include <linux/vmalloc.h>
 
 #include "ipath_kernel.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Roland Dreier]

On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
> Add <linux/stat.h> to fix build errors:

When did this break?  I build ipath in my test config all the time...

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Randy Dunlap]

On 10/07/11 14:21, Roland Dreier wrote:
> On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> Add <linux/stat.h> to fix build errors:
> 
> When did this break?  I build ipath in my test config all the time...

First I saw it was in today's linux-next (20111007).

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Hi all,

On Fri, 07 Oct 2011 15:05:44 -0700 Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
>
> On 10/07/11 14:21, Roland Dreier wrote:
> > On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
> >> Add <linux/stat.h> to fix build errors:
> > 
> > When did this break?  I build ipath in my test config all the time...
> 
> First I saw it was in today's linux-next (20111007).

Its probably associated with the module.h split up.  But see Rule 1 in
Documentation/SubmitChecklist.  Implicit inclusion of files can easily
break when built for a different architecture or config ...

-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Mike Marciniszyn]

As do I.

I've confirmed that patch does no harm, but I would like to see the error.

Which of the github repos exposes the error?

Mike

> -----Original Message-----
> From: Roland Dreier [mailto:roland@purestorage.com]
> Sent: Friday, October 07, 2011 5:21 PM
> To: Randy Dunlap
> Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel;
> Dept_Infinipath; linux-rdma@vger.kernel.org; Andrew Morton
> Subject: Re: [PATCH -next] infiniband: fix ipath_chip_init.c build
> errors
>
> On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap@xenotime.net>
> wrote:
> > Add <linux/stat.h> to fix build errors:
>
> When did this break?  I build ipath in my test config all the time...
>
>  - R.


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Randy Dunlap]

On 10/10/11 11:57, Mike Marciniszyn wrote:
> As do I.
> 
> I've confirmed that patch does no harm, but I would like to see the error.
> 
> Which of the github repos exposes the error?

I saw it in linux-next of 20111007.


> Mike
> 
>> -----Original Message-----
>> From: Roland Dreier [mailto:roland@purestorage.com]
>> Sent: Friday, October 07, 2011 5:21 PM
>> To: Randy Dunlap
>> Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel;
>> Dept_Infinipath; linux-rdma@vger.kernel.org; Andrew Morton
>> Subject: Re: [PATCH -next] infiniband: fix ipath_chip_init.c build
>> errors
>>
>> On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap@xenotime.net>
>> wrote:
>>> Add <linux/stat.h> to fix build errors:
>>
>> When did this break?  I build ipath in my test config all the time...
>>
>>  - R.


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Roland Dreier]

On Fri, Oct 7, 2011 at 3:05 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> First I saw it was in today's linux-next (20111007).

Got it... a latent problem exposed by some include clean up, probably.

Applied, thanks.

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On Mon, 10 Oct 2011 12:02:29 -0700 Roland Dreier <roland@purestorage.com> wrote:
>
> On Fri, Oct 7, 2011 at 3:05 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > First I saw it was in today's linux-next (20111007).
> 
> Got it... a latent problem exposed by some include clean up, probably.

Almost certainly the module.h split up.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

[Mike Marciniszyn]

> Add <linux/stat.h> to fix build errors:
>
> drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: 'S_IRUGO'
> undeclared here (not in a function)
> drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: bit-field
> '<anonymous>' width not an integer constant
> drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: 'S_IWUSR'
> undeclared here (not in a function)
> drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: bit-field
> '<anonymous>' width not an integer constant
>
> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>

Thanks for the patch!

Acked-by: Mike Marciniszyn <mike.marciniszyn-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html