public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size
Date: Tue, 11 Oct 2011 09:24:40 +0200	[thread overview]
Message-ID: <4E93EF38.5040707@mellanox.com> (raw)
In-Reply-To: <CAG4TOxNaQicA6ExuNsw8V95mJPD+AQX5Wrfg+rCoBxdr2E+2ww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 10/10/2011 7:00 PM, Roland Dreier wrote:
> Can we really do this? Doesn't this break anyone who has this option 
> configured in modprobe.conf? 
> This is one reason why I hate adding module parameters -- you can't 
> just delete them later like this 

Yes, I now understand even better why you hate adding module params... 
specifically here, this table relates
only to IBoE users, which is relatively new (in since 2.6.37) and didn't 
hit yet most (if not all) of the
distros,  so I don't expect anything to break, makes sense?

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-10-11  7:24 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10  8:51 [PATCH for-3.2] IBoE fixes Or Gerlitz
     [not found] ` <alpine.LRH.2.00.1110101047420.10901-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-10-10  8:53   ` [PATCH 1/5] ib/mlx4: enable 4K mtu for IBoE Or Gerlitz
2011-10-10  8:54   ` [PATCH 2/5] ib/mlx4: remove setting of vlan in IBoE WQEs control segment Or Gerlitz
2011-10-10  8:55   ` [PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size Or Gerlitz
     [not found]     ` <alpine.LRH.2.00.1110101055050.11243-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-10-10 17:00       ` Roland Dreier
     [not found]         ` <CAG4TOxNaQicA6ExuNsw8V95mJPD+AQX5Wrfg+rCoBxdr2E+2ww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-11  7:24           ` Or Gerlitz [this message]
     [not found]             ` <4E93EF38.5040707-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-10-11 17:28               ` Roland Dreier
     [not found]                 ` <CAL1RGDVk2EOmgWU_iZQWQqKJFPNYN4o_5_14Qbr_6wUzTJ1bOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-11 19:18                   ` Or Gerlitz
     [not found]                     ` <CAJZOPZJnzUm2M1zm1564TUwKCN3r=y3g-4pwTL4bJPDo2V4s9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-11 19:22                       ` Roland Dreier
2011-10-16  8:32                   ` Or Gerlitz
2011-10-16  8:26       ` [PATCH V1 3/5] net/mlx4_core: deprecate " Or Gerlitz
2011-10-10  8:56   ` [PATCH 4/5] ib/core: add support for extended performance counters in sysfs Or Gerlitz
     [not found]     ` <alpine.LRH.2.00.1110101055570.11243-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-10-31 19:38       ` Roland Dreier
     [not found]         ` <CAL1RGDXdkiZNtAsnqDtgbCJGLXLFvk8s-YA5mR189kmg6FkabQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-01  6:40           ` Or Gerlitz
     [not found]             ` <CAJZOPZ+K3u+u5XutGfBhKh3DaBpNRKV_bw67CLK6jy3060OHqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-01 16:22               ` Jason Gunthorpe
     [not found]                 ` <20111101162218.GA10710-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-11-01 17:23                   ` Or Gerlitz
     [not found]                     ` <CAJZOPZLXZL=vEDdXE3rE5Jzw840SrdY=73M7QgKSNzOysRE6MQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-01 17:36                       ` Jason Gunthorpe
     [not found]                         ` <20111101173625.GH26974-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-11-01 18:14                           ` Or Gerlitz
     [not found]                             ` <CAJZOPZJCY5ehTGw8htsxw0dJgMXJJAS-=LGJde9ddcMsmhqvMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-01 18:37                               ` Jason Gunthorpe
     [not found]                                 ` <20111101183730.GI26974-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-11-01 21:42                                   ` Roland Dreier
2011-11-01 21:44                                     ` Or Gerlitz
2011-11-01 21:52                                     ` Jason Gunthorpe
     [not found]                                       ` <20111101215200.GN26974-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-11-01 22:03                                         ` Ira Weiny
     [not found]                                           ` <20111101150358.17d232ee.weiny2-i2BcT+NCU+M@public.gmane.org>
2011-11-01 22:11                                             ` Jason Gunthorpe
     [not found]                                               ` <20111101221135.GP26974-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-11-01 22:19                                                 ` Ira Weiny
2011-11-01 22:34                                                 ` Or Gerlitz
     [not found]                                                   ` <CAJZOPZJh2T5nCsdU9B0anUnoB=SpRD2_yBLT620zEi0Kr12MFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-01 22:46                                                     ` Ira Weiny
     [not found]                                                       ` <20111101154627.f3c847dd.weiny2-i2BcT+NCU+M@public.gmane.org>
2011-11-02  7:38                                                         ` Or Gerlitz
2011-11-02 17:16                                     ` Or Gerlitz
     [not found]                                       ` <4EB17AF9.3000608-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-11-08  0:54                                         ` Roland Dreier
     [not found]                                           ` <CAG4TOxOYAnuB8oKkJgr9_6EpF+YR-h9WNak+gSWwpV0Nz-LeZg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-08  1:09                                             ` Jason Gunthorpe
     [not found]                                               ` <20111108010952.GC4934-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-11-08 16:06                                                 ` Ira Weiny
     [not found]                                                   ` <20111108080606.7c5dd62c.weiny2-i2BcT+NCU+M@public.gmane.org>
2011-12-20 11:49                                                     ` Or Gerlitz
2011-12-20 11:49                                                     ` Or Gerlitz
2011-12-20 12:03                                                 ` Or Gerlitz
     [not found]                                                   ` <4EF07993.2090900-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-12-20 17:46                                                     ` Jason Gunthorpe
     [not found]                                                       ` <20111220174639.GE25774-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-12-20 19:40                                                         ` Or Gerlitz
     [not found]                                                           ` <CAJZOPZ+rBKck50kmyhLZ3VNLNmoS_K6cA3Pj3L6XQjcBQo6DjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-20 19:50                                                             ` Jason Gunthorpe
     [not found]                                                               ` <20111220195014.GH25774-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-12-20 19:56                                                                 ` Or Gerlitz
2012-01-04 19:29                                                                 ` Or Gerlitz
2011-12-22 17:09                                             ` Or Gerlitz
2011-11-01 21:46                                   ` Or Gerlitz
     [not found]                                     ` <CAJZOPZ+zmwTdHva5C7k0QhBmEzxSGTa1Ajszz3eSH=WpP3A4fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-01 21:58                                       ` Jason Gunthorpe
     [not found]                                         ` <20111101215843.GO26974-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-11-02  8:27                                           ` Or Gerlitz
2011-11-01 21:49                               ` Roland Dreier
     [not found]                                 ` <CAG4TOxM4n3=51-3UqYF=iRS25OdRjTXoKDD6u1DukgRrwvTW1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-01 22:32                                   ` Or Gerlitz
2011-11-01 22:49                                   ` Hefty, Sean
2011-10-10  8:57   ` [PATCH 5/5] ib/mlx4: added support for extended PMA counters under IBoE Or Gerlitz
2011-10-26  7:04   ` [PATCH for-3.2] IBoE fixes Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E93EF38.5040707@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox