public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 16/62] infiniband: remove the second argument of k[un]map_atomic()
       [not found] <1322371662-26166-1-git-send-email-amwang@redhat.com>
@ 2011-11-27  5:26 ` Cong Wang
       [not found]   ` <1322371662-26166-17-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Cong Wang @ 2011-11-27  5:26 UTC (permalink / raw)
  To: linux-kernel
  Cc: akpm, Cong Wang, Roland Dreier, Sean Hefty, Hal Rosenstock,
	linux-rdma


Signed-off-by: Cong Wang <amwang@redhat.com>
---
 drivers/infiniband/ulp/iser/iser_memory.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/ulp/iser/iser_memory.c b/drivers/infiniband/ulp/iser/iser_memory.c
index fb88d68..2033a92 100644
--- a/drivers/infiniband/ulp/iser/iser_memory.c
+++ b/drivers/infiniband/ulp/iser/iser_memory.c
@@ -73,11 +73,11 @@ static int iser_start_rdma_unaligned_sg(struct iscsi_iser_task *iser_task,
 
 		p = mem;
 		for_each_sg(sgl, sg, data->size, i) {
-			from = kmap_atomic(sg_page(sg), KM_USER0);
+			from = kmap_atomic(sg_page(sg));
 			memcpy(p,
 			       from + sg->offset,
 			       sg->length);
-			kunmap_atomic(from, KM_USER0);
+			kunmap_atomic(from);
 			p += sg->length;
 		}
 	}
@@ -133,11 +133,11 @@ void iser_finalize_rdma_unaligned_sg(struct iscsi_iser_task *iser_task,
 
 		p = mem;
 		for_each_sg(sgl, sg, sg_size, i) {
-			to = kmap_atomic(sg_page(sg), KM_SOFTIRQ0);
+			to = kmap_atomic(sg_page(sg));
 			memcpy(to + sg->offset,
 			       p,
 			       sg->length);
-			kunmap_atomic(to, KM_SOFTIRQ0);
+			kunmap_atomic(to);
 			p += sg->length;
 		}
 	}
-- 
1.7.4.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 16/62] infiniband: remove the second argument of k[un]map_atomic()
       [not found]   ` <1322371662-26166-17-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2011-11-28  7:38     ` Roland Dreier
       [not found]       ` <CAL1RGDXkh4xJJNO+7fkDXJ4f7LgwvbrHKTueiozUkiK0dkRBZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Roland Dreier @ 2011-11-28  7:38 UTC (permalink / raw)
  To: Cong Wang
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, Sean Hefty, Hal Rosenstock,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA

These look fine, given the second argument is unused.  So

Acked-by: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>

... or is there some point when the <linux/highmem.h> part is
going in and where it makes sense for me to apply this through
my tree?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 16/62] infiniband: remove the second argument of k[un]map_atomic()
       [not found]       ` <CAL1RGDXkh4xJJNO+7fkDXJ4f7LgwvbrHKTueiozUkiK0dkRBZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2011-11-28  7:45         ` Cong Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Cong Wang @ 2011-11-28  7:45 UTC (permalink / raw)
  To: Roland Dreier
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, Sean Hefty, Hal Rosenstock,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA

于 2011年11月28日 15:38, Roland Dreier 写道:
> These look fine, given the second argument is unused.  So
>
> Acked-by: Roland Dreier<roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
>

Thanks, Roland!

> ... or is there some point when the<linux/highmem.h>  part is
> going in and where it makes sense for me to apply this through
> my tree?
>

I think this patchset should be taken as a whole, so either Andrew
takes them all, or let Stephen to merge my tree[1] to linux-next.

But I don't know if Andrew has different opinions.

1. git://github.com/congwang/linux.git #for-next
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-11-28  7:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1322371662-26166-1-git-send-email-amwang@redhat.com>
2011-11-27  5:26 ` [PATCH 16/62] infiniband: remove the second argument of k[un]map_atomic() Cong Wang
     [not found]   ` <1322371662-26166-17-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-11-28  7:38     ` Roland Dreier
     [not found]       ` <CAL1RGDXkh4xJJNO+7fkDXJ4f7LgwvbrHKTueiozUkiK0dkRBZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-28  7:45         ` Cong Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox