[PATCH] opensm: on MAD error call back print DR PATH or LID of request MAD

Ira Weiny
2011-12-14T05:09:18Z

In addition print transaction ID of all DR PATH dumps to make sure we know
which MAD's they refer to.

Signed-off-by: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
---
opensm/osm_helper.c | 5 +++--
opensm/osm_sm_mad_ctrl.c | 7 +++++++
2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c
index f9f3d9d..b6591c4 100644
--- a/opensm/osm_helper.c
+++ b/opensm/osm_helper.c
@@ -2059,8 +2059,9 @@ void osm_dump_smp_dr_path(IN osm_log_t * p_log, IN const ib_smp_t * p_smp,
char buf[BUF_SIZE];
unsigned n;

- n = sprintf(buf, "Received SMP on a %u hop path: "
- "Initial path = ", p_smp->hop_count);
+ n = sprintf(buf, "Received SMP (TID 0x%" PRIx64 ") on a %u hop path: "
+ "Initial path = ",
+ cl_ntoh64(p_smp->trans_id), p_smp->hop_count);
n += sprint_uint8_arr(buf + n, sizeof(buf) - n,
p_smp->initial_path,
p_smp->hop_count + 1);
diff --git a/opensm/osm_sm_mad_ctrl.c b/opensm/osm_sm_mad_ctrl.c
index ee92c66..6abf8b8 100644
--- a/opensm/osm_sm_mad_ctrl.c
+++ b/opensm/osm_sm_mad_ctrl.c
@@ -721,6 +721,13 @@ static void sm_mad_ctrl_send_err_cb(IN void *context, IN osm_madw_t * p_madw)
ib_get_sm_attr_str(p_smp->attr_id), cl_ntoh32(p_smp->attr_mod),
cl_ntoh64(p_smp->trans_id));

+ if (p_smp->mgmt_class == IB_MCLASS_SUBN_DIR) {
+ osm_dump_smp_dr_path(p_ctrl->p_log, p_smp, OSM_LOG_ERROR);
+ } else {
+ OSM_LOG(p_ctrl->p_log, OSM_LOG_ERROR, "LID %u\n",
+ cl_ntoh16(p_madw->mad_addr.dest_lid));
+ }
+
/*
If this was a SubnSet MAD, then this error might indicate a problem
in configuring the subnet. In this case - need to mark that there was
--
1.7.1