From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated TCP streams Date: Mon, 30 Jan 2012 10:11:00 +0200 Message-ID: <4F265094.1010004@mellanox.com> References: <4F264A6C.3070706@mellanox.com> <1327910672.2891.12.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1327910672.2891.12.camel@edumazet-laptop> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Dumazet Cc: Roland Dreier , Herbert Xu , davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-rdma , Shlomo Pongratz , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 1/30/2012 10:04 AM, Eric Dumazet wrote: > Hmm, do we really need to compare ether header, thats the question. > IMHO, GRO could avoid this check, as legal trafic could be never > merged (eg multipath) Yep, basically I tend to agree that GRO could do very well with L3 and L4 checks, the multipath comment is interesting use case to show why the ethernet header comparison might be too strict here. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html