Re: [PATCH] iw_cm: Call provider listen_destroy function before changing state.

[Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

On 02/22/2012 02:32 PM, Roland Dreier wrote:
> On Wed, Feb 22, 2012 at 11:43 AM, Steve Wise
> <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>  wrote:
>>       spin_lock_irqsave(&cm_id_priv->lock, flags);
>>         switch (cm_id_priv->state) {
>>         case IW_CM_STATE_LISTEN:
>> -               cm_id_priv->state = IW_CM_STATE_DESTROYING;
>>                 spin_unlock_irqrestore(&cm_id_priv->lock, flags);
>>                 /* destroy the listening endpoint */
>>                 ret = cm_id->device->iwcm->destroy_listen(cm_id);
>>                 spin_lock_irqsave(&cm_id_priv->lock, flags);
>> +               cm_id_priv->state = IW_CM_STATE_DESTROYING;
>>                 break;
>>         case IW_CM_STATE_ESTABLISHED:
>>                 cm_id_priv->state = IW_CM_STATE_DESTROYING;
> This seems a bit wonky to me... with the old code, we set the state to
> DESTROYING inside the lock, so we know all previous connections
> were either done with their locked region or saw the new state.
>
> Now we have a window where are done with destroy_listen() but
> the state is still not DESTROYING.
>
> Is it possible to have the provider reject requests instead of silently
> dropping them?  Would that be a better fix?
>

Perhaps.   Or the connect request event handler could return a status indicating whether or not it queued the request 
and will subsequently accept or reject it.



>   - R.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html