From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [Patch] iser: free ib connection resources in the proper place
Date: Tue, 28 Feb 2012 18:53:24 +0200 [thread overview]
Message-ID: <4F4D0684.8090504@mellanox.com> (raw)
In-Reply-To: <35056e0cff3c2ea514095edf5445b9c7fd2fd631.1330198520.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 2/25/2012 9:36 PM, Doug Ledford wrote:
> We allocate the login dma buffers in iser_verbs.c as part of
> alloc_ib_conn_resources(), however we are freeing them in
> iser_initiator.c as part of iser_free_rx_descriptors(). This is
> needlessly confusing. We have an alloc_rx_descriptors() and it doesn't
> alloc something that the free_rx_descriptors() frees, and we have an
> alloc_ib_conn_resources() that allocs something not freed by
> free_ib_conn_resources(). Clean that up.
seems okay, I will test and ack by Thursday
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-28 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 19:36 [Patch] iser: free ib connection resources in the proper place Doug Ledford
[not found] ` <35056e0cff3c2ea514095edf5445b9c7fd2fd631.1330198520.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-02-28 16:53 ` Or Gerlitz [this message]
2012-03-01 17:35 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4D0684.8090504@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox