From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [Patch] iser: free ib connection resources in the proper place
Date: Thu, 1 Mar 2012 19:35:40 +0200 [thread overview]
Message-ID: <4F4FB36C.9080008@mellanox.com> (raw)
In-Reply-To: <35056e0cff3c2ea514095edf5445b9c7fd2fd631.1330198520.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 2/25/2012 9:36 PM, Doug Ledford wrote:
>
> @@ -274,6 +274,18 @@ static int iser_free_ib_conn_res(struct iser_conn *ib_conn, int can_destroy_id)
> ib_conn->cma_id = NULL;
> kfree(ib_conn->page_vec);
>
> + if (ib_conn->login_buf) {
> + if (ib_conn->login_req_dma)
> + ib_dma_unmap_single(device->ib_device,
> + ib_conn->login_req_dma,
> + ISCSI_DEF_MAX_RECV_SEG_LEN, DMA_TO_DEVICE);
>
Doug, this failed to build against 3.3-rc5, I will fix and repost with
you being the author
Or.
> CC [M] drivers/infiniband/ulp/iser/iser_verbs.o
> drivers/infiniband/ulp/iser/iser_verbs.c: In function
> iser_free_ib_conn_res:
> drivers/infiniband/ulp/iser/iser_verbs.c:279: error: device undeclared
> (first use in this function)
> drivers/infiniband/ulp/iser/iser_verbs.c:279: error: (Each undeclared
> identifier is reported only once
> drivers/infiniband/ulp/iser/iser_verbs.c:279: error: for each function
> it appears in.)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-03-01 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 19:36 [Patch] iser: free ib connection resources in the proper place Doug Ledford
[not found] ` <35056e0cff3c2ea514095edf5445b9c7fd2fd631.1330198520.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-02-28 16:53 ` Or Gerlitz
2012-03-01 17:35 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4FB36C.9080008@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox