From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
Subject: Re: mlx4: kernel 3.4-rc1 breaks libumad
Date: Mon, 2 Apr 2012 17:51:13 +0300 [thread overview]
Message-ID: <4F79BCE1.7010308@mellanox.com> (raw)
In-Reply-To: <4F79A8C4.5000604-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On 4/2/2012 4:25 PM, Hal Rosenstock wrote:
>
> I think there are 3 main issues here:
> 1. EINVAL can be returned from rate_show and hence "Invalid argument"
> rate string should be handled in libibumad. I think this was Bart's original point.
> 2. Why is rate_show returning EINVAL ? I think that's what you're trying
> to isolate with the additional printks you sent Bart for sysfs.c.
> 3. link_layer ethernet should also be handled which is the issue you raised.
Just to sync, I just sent kernel patches which should eliminate the case
when EINVAL is seen by rate_show after calling into the mlx4 driver.
This addresses point #2, as for #3, I made a check and forced Ethernet
link layer on IB port, in this case the mlx4 driver issues the ethernet
port query command and it returns valid value for active_speed (4) so I
didn't patch that code too. As for libibumad fixes, I'm not dealing with
that...
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-04-02 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 7:42 mlx4: kernel 3.4-rc1 breaks libumad Bart Van Assche
[not found] ` <4F795880.4070306-HInyCGIudOg@public.gmane.org>
2012-04-02 10:33 ` Or Gerlitz
[not found] ` <4F798069.4030305-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-04-02 11:16 ` Bart Van Assche
[not found] ` <4F798A9B.7060805-HInyCGIudOg@public.gmane.org>
2012-04-02 11:20 ` Or Gerlitz
[not found] ` <4F798B9A.6090309-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-04-02 11:48 ` Bart Van Assche
[not found] ` <4F799222.3050306-HInyCGIudOg@public.gmane.org>
2012-04-02 12:51 ` Or Gerlitz
[not found] ` <4F79A0C5.2030805-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-04-02 13:02 ` Or Gerlitz
[not found] ` <4F79A359.2020204-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-04-02 13:25 ` Hal Rosenstock
[not found] ` <4F79A8C4.5000604-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-04-02 14:10 ` Hal Rosenstock
2012-04-02 14:51 ` Or Gerlitz [this message]
2012-04-03 21:37 ` Ira Weiny
2012-04-02 13:35 ` Bart Van Assche
[not found] ` <4F79AB24.2090200-HInyCGIudOg@public.gmane.org>
2012-04-02 14:06 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79BCE1.7010308@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=weiny2-i2BcT+NCU+M@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox