From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: ibacm fixes/updates Date: Thu, 05 Apr 2012 12:11:39 -0400 Message-ID: <4F7DC43B.6070605@redhat.com> References: <4F4D424F.3040004@redhat.com> <1828884A29C6694DAF28B7E6B8A823734519A54B@ORSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1EFBAB26D0D7BF387784F6E5" Return-path: In-Reply-To: <1828884A29C6694DAF28B7E6B8A823734519A54B-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1EFBAB26D0D7BF387784F6E5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04/02/2012 04:49 PM, Hefty, Sean wrote: >> By default ibacm expects to find its configuration files in /etc/ibacm= =2E >> This adds to the proliferation of directories in /etc/ needlessly. W= e >> already have a number of RDMA related directories to choose from >> depending on your install (OFED =3D=3D /etc/ofed or /etc/openib in the= old >> days, RHEL5 =3D=3D /etc/openib from the old days, RHEL6 and Fedora are= >> /etc/rdma, don't know what SuSE uses). Would be best if these files >> were in the same place as the other RDMA related files. And to make >> that happen easily, it would be best if they picked up on %{sysconfdir= } >> from the ./configure invocation in order to set the directory. I used= a >> static patch for now because I'm behind on my work, so updating the >> configure script was more than I had time to do. I'm not bothering to= >> include my patch as it needs done the other way so my patch is purely = a >> stopgap that should not see the time of day ;-) >=20 > I've moved the config files to /etc/rdma. I'm still trying to figure o= ut how to make them use %{sysconfdir}, so I can avoid hard coding any pat= hs. >=20 > Note that the config files are NOT needed by default. If the option co= nfig file (acm_opts.cfg) is not found, the ibacm service will simply use = the default settings. The default values are the same as defined in the = sample option file. >=20 > The acm_addr.cfg file included with the package is a sample file only. = The address file should be generated by running the ib_acme program on t= he same node. Copying the acm_addr.cfg file included with the package wi= ll not work, since the addresses must be unique per node. If no address = config file is found, the ibacm service will automatically call ib_acme t= o generate one. >=20 > So... I think you want to remove the following install lines from your = makefile.am patch. >=20 > +install-exec-hook: > + if ! test -d $(DESTDIR)$(sysconfdir); then \ > + mkdir -p $(DESTDIR)$(sysconfdir); \ > + fi; \ > + install -m 644 acm_opts.cfg $(DESTDIR)$(sysconfdir)/acm_opts.cfg; \ > + install -m 644 acm_addr.cfg $(DESTDIR)$(sysconfdir)/acm_addr.cfg; OK, will do. --=20 Doug Ledford GPG KeyID: 0E572FDD http://people.redhat.com/dledford --------------enig1EFBAB26D0D7BF387784F6E5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPfcQ7AAoJELgmozMOVy/dF7oP/3TTGkVtXSZi65NNz7Es4DOJ r4Iz37mzWMxW8qnU+TgPMT1nIz040tWKXOaO+x19CGj9Fkohaoez8nwREucn96Kj pmcTKZtSTLisktimdhOqcUjR5a4zNdJLvjJz5fRp1Fw4Wc68acuK3q2+hn89GtCz CokzSgh2Qgo0P3ARzaNLcxGILnJUVmPXJcK+E67Q4ORiypKFuYiiQ0UuCxLgktx7 Jk405cMVbpl0Xh9uNKF8xohfihGyhh+gz3WHTMTZ1nLhlE0Z93VrWC/Ts6gkj/20 ev9JBqnad+4YUKwzkbtG1epITf+ya0IZ3Qh3kCPCWp44wrigwDOj2VvXqxvy3OXk O2QL0n7DmpLI1uVjKMNyjqpl/nZuk0iTRKEp44ChiAkFZ65puJe0YPKezOnWULPj OY0BYYADR1IABuqOSAqp7y/8trEBllHcMY0fPH3s5ZYiDx4nDk5hmbLYHYIXX9l5 aQwQPi70Zpb9j7EZUiJ0ErjyHd8bQELyszP6ARqdu/lnlvVTBvXUlI2W9/D+rdph HANAFrRAaGMQd6/rsEw1RIhA+WyxxfWRk+srvxJYs3jwHC/67hUY+kUa51N84X5l TFq6rnOiGix5Ffk9jrbErmo4n2pX9ALtJW9m1CcjPI2A30KNcgQPUPVDivdqxftT ua+CVoSn8qQy38F5Elzf =dZC3 -----END PGP SIGNATURE----- --------------enig1EFBAB26D0D7BF387784F6E5-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html