public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ibacm/libacm.c: Use IPv4 rather than IPv6 for ACM server communication
@ 2012-04-05 20:05 Hal Rosenstock
       [not found] ` <4F7DFB04.2030803-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Hal Rosenstock @ 2012-04-05 20:05 UTC (permalink / raw)
  To: Hefty, Sean
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)


When both IPv4 and IPv6 are running, getaddrinfo indicates IPv6
rather than IPv4 and that currently causes a failure to connect to
the ACM server. Fix is to set the address family in the hint to
getaddrinfo to IPv4.

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/libacm.c b/src/libacm.c
index 727741f..5ca1abc 100644
--- a/src/libacm.c
+++ b/src/libacm.c
@@ -75,6 +75,7 @@ int ib_acm_connect(char *dest)
 
 	acm_set_server_port();
 	memset(&hint, 0, sizeof hint);
+	hint.ai_family = AF_INET;
 	hint.ai_protocol = IPPROTO_TCP;
 	ret = getaddrinfo(dest, NULL, &hint, &res);
 	if (ret)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ibacm/libacm.c: Use IPv4 rather than IPv6 for ACM server communication
       [not found] ` <4F7DFB04.2030803-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2012-04-05 20:51   ` Jason Gunthorpe
  2012-04-05 23:28   ` Hefty, Sean
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2012-04-05 20:51 UTC (permalink / raw)
  To: Hal Rosenstock
  Cc: Hefty, Sean,
	linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)

On Thu, Apr 05, 2012 at 04:05:24PM -0400, Hal Rosenstock wrote:
 
> When both IPv4 and IPv6 are running, getaddrinfo indicates IPv6
> rather than IPv4 and that currently causes a failure to connect to
> the ACM server. Fix is to set the address family in the hint to
> getaddrinfo to IPv4.

We are in the future, the daemon should listen for IPv6 connections.

Drepper has a description on how to do this properly:

http://www.akkadia.org/drepper/userapi-ipv6.html

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] ibacm/libacm.c: Use IPv4 rather than IPv6 for ACM server communication
       [not found] ` <4F7DFB04.2030803-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  2012-04-05 20:51   ` Jason Gunthorpe
@ 2012-04-05 23:28   ` Hefty, Sean
  1 sibling, 0 replies; 3+ messages in thread
From: Hefty, Sean @ 2012-04-05 23:28 UTC (permalink / raw)
  To: Hal Rosenstock
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)

thanks - applied

I will add a separate patch to support IPv6, since librdmacm should be updated as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-05 23:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-05 20:05 [PATCH] ibacm/libacm.c: Use IPv4 rather than IPv6 for ACM server communication Hal Rosenstock
     [not found] ` <4F7DFB04.2030803-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-04-05 20:51   ` Jason Gunthorpe
2012-04-05 23:28   ` Hefty, Sean

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox