Re: [PATCH] ibacm: Fixes to ACM package to support distros

Jason Gunthorpe
2012-04-05T20:40:38Z

On Thu, Apr 05, 2012 at 07:10:25PM +0000, Hefty, Sean wrote:
> > > +PATH=$PATH:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> >
> > I'm not very keen on including /usr/local in the search path on system

> To say that I'm not sure what autotools and the init scripts are
> doing is an understatement... The init script finds ibacm in
> /usr/sbin, but not /usr/local/sbin where it ended up being
> installed. I'm not sure how to fix that.

In this instance you need to have configure variable substitute your
init script as well. You should not manipulate PATH from an init.d
script, and you should use an absolute path to the daemon to avoid
contamination from the invoking user's environment.

So you want:

%prefix$/bin/IBACM_BIN -foo

(use start-stop-daemon if appropriate for RHEL, I'm not sure what
their conventions are...)

There might be a better choice than %prefix% for this, check the
config.sub output for a better substitution.

Also, these days it would be very forward-thinking of you to
contemplate how this will work in a systemd world. Make sure it can be
demand started, have a daemon that has a running mode that is systemd
compatible, etc. I think Doug was saying that the latest FC has IB and
systemd together?

Jason