From: Bernd Schubert <bernd.schubert-97jfqw80gc6171pxa8y+qA@public.gmane.org>
To: Bernd Schubert
<bernd.schubert-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
Cc: David Dillow <dillowda-1Heg1YXhbW8@public.gmane.org>,
Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>,
James Bottomley
<James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>,
"linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] srp: convert SRP_RQ_SHIFT into a module parameter
Date: Mon, 21 May 2012 21:35:13 +0200 [thread overview]
Message-ID: <4FBA98F1.40103@fastmail.fm> (raw)
In-Reply-To: <4FBA6412.7040505-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
> @@ -2131,9 +2171,15 @@ static ssize_t srp_create_target(struct device *dev,
> target_host->max_id = 1;
> target_host->max_lun = SRP_MAX_LUN;
> target_host->max_cmd_len = sizeof ((struct srp_cmd *) (void *) 0L)->cdb;
> + target_host->can_queue = srp_cmd_sq_size;
> + target_host->cmd_per_lun = srp_cmd_sq_size;
>
> target = host_to_target(target_host);
>
> + ret = srp_alloc_target_rings(target);
> + if (ret)
> + goto err;
Here is a memory leak if something fails below, I need to add another
goto target.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-21 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4FB39D78.9020300@itwm.fraunhofer.de>
[not found] ` <1337177200.2985.71.camel@dabdike.int.hansenpartnership.com>
[not found] ` <4FB3B9DE.1050903@itwm.fraunhofer.de>
[not found] ` <4FB3C75F.3070903@cs.wisc.edu>
[not found] ` <4FB3C75F.3070903-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2012-05-16 15:54 ` [dm-devel] multipath_busy() stalls IO due to scsi_host_is_busy() Bernd Schubert
[not found] ` <4FB3CDC5.9040608-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2012-05-16 17:03 ` David Dillow
2012-05-16 20:34 ` Bernd Schubert
2012-05-21 15:49 ` [PATCH] srp: convert SRP_RQ_SHIFT into a module parameter Bernd Schubert
[not found] ` <4FBA6412.7040505-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2012-05-21 19:35 ` Bernd Schubert [this message]
2012-05-30 5:22 ` David Dillow
[not found] ` <1338355352.2361.24.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2012-05-30 5:24 ` David Dillow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA98F1.40103@fastmail.fm \
--to=bernd.schubert-97jfqw80gc6171pxa8y+qa@public.gmane.org \
--cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=bernd.schubert-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org \
--cc=dillowda-1Heg1YXhbW8@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox