[PATCH] ibacm/acme.c: Eliminate seg fault when source not supplied

[PATCH] ibacm/acme.c: Eliminate seg fault when source not supplied

[Hal Rosenstock]

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/acme.c b/src/acme.c
index d3f8174..533588c 100644
--- a/src/acme.c
+++ b/src/acme.c
@@ -618,12 +618,18 @@ static void resolve(char *svc)
 				ret = resolve_name(&path);
 				break;
 			case 'l':
-				memset(&path, 0, sizeof path);
-				ret = resolve_lid(&path);
+				if (src_addr) {
+					memset(&path, 0, sizeof path);
+					ret = resolve_lid(&path);
+				} else
+					ret = -1;
 				break;
 			case 'g':
-				memset(&path, 0, sizeof path);
-				ret = resolve_gid(&path);
+				if (src_addr) {
+					memset(&path, 0, sizeof path);
+					ret = resolve_gid(&path);
+				} else
+					ret = -1;
 				break;
 			default:
 				break;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ibacm/acme.c: Eliminate seg fault when source not supplied

[Hefty, Sean]

> diff --git a/src/acme.c b/src/acme.c
> index d3f8174..533588c 100644
> --- a/src/acme.c
> +++ b/src/acme.c
> @@ -618,12 +618,18 @@ static void resolve(char *svc)
>  				ret = resolve_name(&path);
>  				break;
>  			case 'l':
> -				memset(&path, 0, sizeof path);
> -				ret = resolve_lid(&path);
> +				if (src_addr) {
> +					memset(&path, 0, sizeof path);
> +					ret = resolve_lid(&path);
> +				} else
> +					ret = -1;
>  				break;
>  			case 'g':
> -				memset(&path, 0, sizeof path);
> -				ret = resolve_gid(&path);
> +				if (src_addr) {
> +					memset(&path, 0, sizeof path);
> +					ret = resolve_gid(&path);
> +				} else
> +					ret = -1;
>  				break;
>  			default:
>  				break;

Thanks.

For this problem, I'd prefer to check for a NULL src_addr in resolve_lid and resolve_gid.  The ibacm service could then select a SLID/SGID based on the specified DLID/DGID.  This makes things easier for the user.

But until ibacm handles a 0 SLID/SGID, have ib_acme provide a more usable failure message.

I can make this patch if this sounds workable to you.

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ibacm/acme.c: Eliminate seg fault when source not supplied

[Hal Rosenstock]

On 5/31/2012 8:04 PM, Hefty, Sean wrote:
>> diff --git a/src/acme.c b/src/acme.c
>> index d3f8174..533588c 100644
>> --- a/src/acme.c
>> +++ b/src/acme.c
>> @@ -618,12 +618,18 @@ static void resolve(char *svc)
>>  				ret = resolve_name(&path);
>>  				break;
>>  			case 'l':
>> -				memset(&path, 0, sizeof path);
>> -				ret = resolve_lid(&path);
>> +				if (src_addr) {
>> +					memset(&path, 0, sizeof path);
>> +					ret = resolve_lid(&path);
>> +				} else
>> +					ret = -1;
>>  				break;
>>  			case 'g':
>> -				memset(&path, 0, sizeof path);
>> -				ret = resolve_gid(&path);
>> +				if (src_addr) {
>> +					memset(&path, 0, sizeof path);
>> +					ret = resolve_gid(&path);
>> +				} else
>> +					ret = -1;
>>  				break;
>>  			default:
>>  				break;
> 
> Thanks.
> 
> For this problem, I'd prefer to check for a NULL src_addr in resolve_lid and resolve_gid.  The ibacm service could then select a SLID/SGID based on the specified DLID/DGID.  This makes things easier for the user.
> 
> But until ibacm handles a 0 SLID/SGID, have ib_acme provide a more usable failure message.
> 
> I can make this patch if this sounds workable to you.

Sure; sounds like a better approach. Thanks.

-- Hal

> 
> - Sean
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html