Re: [PATCH V3.1 8/8] infiniband-diags: Add sa_smkey option to config file

[Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 5/30/2012 6:15 PM, Jim Foraker wrote:
> Defines a default for the smkey used in SA requests
> 
> Signed-off-by: Jim Foraker <foraker1-i2BcT+NCU+M@public.gmane.org>
> ---
>  etc/ibdiag.conf     |    3 +++
>  src/ibdiag_common.c |    3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/etc/ibdiag.conf b/etc/ibdiag.conf
> index 2a2334f..9686d14 100644
> --- a/etc/ibdiag.conf
> +++ b/etc/ibdiag.conf
> @@ -17,3 +17,6 @@
>  
>  # define a default m_key
>  #m_key=0x00
> +
> +# default smkey to be used for SA requests
> +#sa_key=0x00

I think we're in for support questions here mostly around MCMemberRecord :-(

If this is to be done, at a minimum, the change in admin expectation
needs to be clearly documented in the infiniband-diags release notes.
I'm not sure that's sufficient to have it noticed.

-- Hal

> diff --git a/src/ibdiag_common.c b/src/ibdiag_common.c
> index eaf504f..ba0ce0b 100644
> --- a/src/ibdiag_common.c
> +++ b/src/ibdiag_common.c
> @@ -160,6 +160,9 @@ void read_ibdiag_config(const char *file)
>  			}
>  		} else if (strncmp(name, "m_key", strlen("m_key")) == 0) {
>  			ibd_mkey = strtoull(val_str, 0, 0);
> +		} else if (strncmp(name, "sa_key",
> +				   strlen("sa_key")) == 0) {
> +			ibd_sakey = strtoull(val_str, 0, 0);
>  		}
>  	}
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html