From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hal Rosenstock Subject: Re: [PATCH] ibacm/acme.c: Eliminate seg fault when source not supplied Date: Thu, 31 May 2012 20:10:01 -0400 Message-ID: <4FC80859.8020307@dev.mellanox.co.il> References: <4FC6919E.9090805@dev.mellanox.co.il> <1828884A29C6694DAF28B7E6B8A8237346A255F3@ORSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237346A255F3-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)" List-Id: linux-rdma@vger.kernel.org On 5/31/2012 8:04 PM, Hefty, Sean wrote: >> diff --git a/src/acme.c b/src/acme.c >> index d3f8174..533588c 100644 >> --- a/src/acme.c >> +++ b/src/acme.c >> @@ -618,12 +618,18 @@ static void resolve(char *svc) >> ret = resolve_name(&path); >> break; >> case 'l': >> - memset(&path, 0, sizeof path); >> - ret = resolve_lid(&path); >> + if (src_addr) { >> + memset(&path, 0, sizeof path); >> + ret = resolve_lid(&path); >> + } else >> + ret = -1; >> break; >> case 'g': >> - memset(&path, 0, sizeof path); >> - ret = resolve_gid(&path); >> + if (src_addr) { >> + memset(&path, 0, sizeof path); >> + ret = resolve_gid(&path); >> + } else >> + ret = -1; >> break; >> default: >> break; > > Thanks. > > For this problem, I'd prefer to check for a NULL src_addr in resolve_lid and resolve_gid. The ibacm service could then select a SLID/SGID based on the specified DLID/DGID. This makes things easier for the user. > > But until ibacm handles a 0 SLID/SGID, have ib_acme provide a more usable failure message. > > I can make this patch if this sounds workable to you. Sure; sounds like a better approach. Thanks. -- Hal > > - Sean > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html