public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ibnetdiscover: fix not showing FDR10 speeds
@ 2012-07-05 16:42 Hal Rosenstock
       [not found] ` <4FF5C40D.7020209-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Hal Rosenstock @ 2012-07-05 16:42 UTC (permalink / raw)
  To: Ira Weiny
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Daniel Klein

Fix: ibnetdiscover shows FDR10 speeds as QDR due to bug in setting
default parameters.

Signed-off-by: Daniel Klein <danielk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 src/ibnetdiscover.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/ibnetdiscover.c b/src/ibnetdiscover.c
index fe785b3..7e35449 100644
--- a/src/ibnetdiscover.c
+++ b/src/ibnetdiscover.c
@@ -1108,6 +1108,8 @@ int main(int argc, char **argv)
 	if (ibd_timeout)
 		config.timeout_ms = ibd_timeout;
 
+	config.flags = ibd_ibnetdisc_flags;
+
 	if (argc && !(f = fopen(argv[0], "w")))
 		IBERROR("can't open file %s for writing", argv[0]);
 
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ibnetdiscover: fix not showing FDR10 speeds
       [not found] ` <4FF5C40D.7020209-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2012-07-05 18:40   ` Or Gerlitz
       [not found]     ` <CAJZOPZJBFkyemvnK12-NxF7L+MkWnop79=6NZk=NonmztRKHNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  2012-07-08  0:21   ` Ira Weiny
  1 sibling, 1 reply; 4+ messages in thread
From: Or Gerlitz @ 2012-07-05 18:40 UTC (permalink / raw)
  To: Hal Rosenstock
  Cc: Ira Weiny,
	linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Daniel Klein

> ibnetdiscover shows FDR10 speeds as QDR due to bug in setting
> default parameters

How old is this bug?

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ibnetdiscover: fix not showing FDR10 speeds
       [not found]     ` <CAJZOPZJBFkyemvnK12-NxF7L+MkWnop79=6NZk=NonmztRKHNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2012-07-05 19:01       ` Hal Rosenstock
  0 siblings, 0 replies; 4+ messages in thread
From: Hal Rosenstock @ 2012-07-05 19:01 UTC (permalink / raw)
  To: Or Gerlitz
  Cc: Ira Weiny,
	linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Daniel Klein

On 7/5/2012 2:40 PM, Or Gerlitz wrote:
>> ibnetdiscover shows FDR10 speeds as QDR due to bug in setting
>> default parameters
> 
> How old is this bug?

Since commit d8648e9d603e469d0fbd90d18b4c99e725d05812 which provided
option to disable FDR10 MADs (in case of kernel issue which was
subsequently fixed).

-- Hal

> 
> Or.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ibnetdiscover: fix not showing FDR10 speeds
       [not found] ` <4FF5C40D.7020209-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  2012-07-05 18:40   ` Or Gerlitz
@ 2012-07-08  0:21   ` Ira Weiny
  1 sibling, 0 replies; 4+ messages in thread
From: Ira Weiny @ 2012-07-08  0:21 UTC (permalink / raw)
  To: Hal Rosenstock
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Daniel Klein

On Thu, 05 Jul 2012 12:42:53 -0400
Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:

> Fix: ibnetdiscover shows FDR10 speeds as QDR due to bug in setting
> default parameters.
> 
> Signed-off-by: Daniel Klein <danielk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks applied,
Ira

> ---
>  src/ibnetdiscover.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/ibnetdiscover.c b/src/ibnetdiscover.c
> index fe785b3..7e35449 100644
> --- a/src/ibnetdiscover.c
> +++ b/src/ibnetdiscover.c
> @@ -1108,6 +1108,8 @@ int main(int argc, char **argv)
>  	if (ibd_timeout)
>  		config.timeout_ms = ibd_timeout;
>  
> +	config.flags = ibd_ibnetdisc_flags;
> +
>  	if (argc && !(f = fopen(argv[0], "w")))
>  		IBERROR("can't open file %s for writing", argv[0]);
>  
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Ira Weiny
Member of Technical Staff
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-07-08  0:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-05 16:42 [PATCH] ibnetdiscover: fix not showing FDR10 speeds Hal Rosenstock
     [not found] ` <4FF5C40D.7020209-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-07-05 18:40   ` Or Gerlitz
     [not found]     ` <CAJZOPZJBFkyemvnK12-NxF7L+MkWnop79=6NZk=NonmztRKHNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-05 19:01       ` Hal Rosenstock
2012-07-08  0:21   ` Ira Weiny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox