From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma
(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Philipp Thomas <pth-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH] opensm/main.c: Handle daemon mode with guid specified as 0 more gracefully
Date: Mon, 09 Jul 2012 13:15:10 -0400 [thread overview]
Message-ID: <4FFB119E.2090805@dev.mellanox.co.il> (raw)
As pointed out by Philipp Thomas <pth-l3A5Bk7waGM@public.gmane.org>:
Currently opensm will silently fail if you pass '-g 0 -B'. As you can't
ask for a port, exit with failure so admin can see the reason
for opensm's failure.
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/opensm/main.c b/opensm/main.c
index 4218cc6..fca209a 100644
--- a/opensm/main.c
+++ b/opensm/main.c
@@ -1120,8 +1120,14 @@ int main(int argc, char *argv[])
block_signals();
- if (opt.daemon)
+ if (opt.daemon) {
+ if (INVALID_GUID == opt.guid) {
+ fprintf(stderr,
+ "ERROR: Invalid GUID specified; exiting because of daemon mode\n");
+ return -1;
+ }
daemonize(&osm);
+ }
complib_init();
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2012-07-09 17:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 17:15 Hal Rosenstock [this message]
[not found] ` <4FFB119E.2090805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-07-25 7:52 ` [PATCH] opensm/main.c: Handle daemon mode with guid specified as 0 more gracefully Alex Netes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFB119E.2090805@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pth-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).