From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova Date: Fri, 2 Jun 2017 16:31:18 -0400 Message-ID: <4c164e09-0103-7daf-e9f8-9260223ada08@fb.com> References: <20170523114404.20387-1-saeedm@mellanox.com> <20170523114404.20387-5-saeedm@mellanox.com> <20170524165059.42lmrwzzcxvi2sf7@ast-mbp> <00716e5a-8b51-0b3f-a1b8-1bb7b346a66a@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Ilan Tayari , Saeed Mahameed Cc: Alexei Starovoitov , Saeed Mahameed , "David S. Miller" , Doug Ledford , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Kernel Team List-Id: linux-rdma@vger.kernel.org On 05/28/2017 03:24 AM, Ilan Tayari wrote: >> -----Original Message----- >> From: Jes Sorensen [mailto:jsorensen@fb.com] >> >> On 05/26/2017 04:29 AM, Saeed Mahameed wrote: >>> On Thu, May 25, 2017 at 11:48 PM, Jes Sorensen wrote: >>>> On 05/25/2017 06:40 AM, Saeed Mahameed wrote: >>> Hi Jes, >>> >>> No, It is clearly stated in the commit message : >>> >>> "The FPGA is a bump-on-the-wire and thus affects operation of >>> the mlx5_core driver on the ConnectX ASIC." >>> >>> Which means mlx5 FPGA user can only write logic which affects only >>> packets going in/out >>> A ConnectX chip - so it is only network stuff -. >>> >>>> We have this with other devices in the kernel where a primary device >> driver >>>> provides an interface for an additional sub-driver to access another >> device >>>> behind it. Like bt-coexist in some of the wifi drivers allowing access >> to a >>>> bluetooth device behind it. >>> >>> Blutooth over wifi or vise versa is a very good example to what you >>> are requesting. >>> But, it doesn't fit to what we are trying to do here. mlx5 FGPA is a >>> ConnectX card feature, not a new protocol. >> >> In that case it would need to be an optional module that can be enabled >> or disabled at build time. > > Jes, > > It is already modular like that. See CONFIG_MLX5_FPGA. [jes@xpeas netdev.git]$ grep CONFIG_MLX5_FPGA drivers/net/ethernet/mellanox/mlx5/core/* [jes@xpeas netdev.git]$ Which git tree am I supposed to look at? Jes