From: Leon Romanovsky <leon@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
linux-netdev <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Raed Salem <raeds@nvidia.com>
Subject: [PATCH mlx5-next 14/17] net/mlx5: Remove not-supported ICV length
Date: Sun, 10 Apr 2022 11:28:32 +0300 [thread overview]
Message-ID: <4d8103cc94fc14d1ee72b50065dec3bf98856f0f.1649578827.git.leonro@nvidia.com> (raw)
In-Reply-To: <cover.1649578827.git.leonro@nvidia.com>
From: Leon Romanovsky <leonro@nvidia.com>
mlx5 doesn't allow to configure any AEAD ICV length other than 128,
so remove the logic that configures other unsupported values.
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
.../mellanox/mlx5/core/en_accel/ipsec_offload.c | 17 +----------------
include/linux/mlx5/mlx5_ifc.h | 2 --
2 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c
index 1dc8588635e9..4f3ffe5a09fa 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c
@@ -63,22 +63,7 @@ static int mlx5_create_ipsec_obj(struct mlx5e_ipsec_sa_entry *sa_entry)
salt_p = MLX5_ADDR_OF(ipsec_obj, obj, salt);
memcpy(salt_p, &aes_gcm->salt, sizeof(aes_gcm->salt));
- switch (aes_gcm->icv_len) {
- case 64:
- MLX5_SET(ipsec_obj, obj, icv_length,
- MLX5_IPSEC_OBJECT_ICV_LEN_8B);
- break;
- case 96:
- MLX5_SET(ipsec_obj, obj, icv_length,
- MLX5_IPSEC_OBJECT_ICV_LEN_12B);
- break;
- case 128:
- MLX5_SET(ipsec_obj, obj, icv_length,
- MLX5_IPSEC_OBJECT_ICV_LEN_16B);
- break;
- default:
- return -EINVAL;
- }
+ MLX5_SET(ipsec_obj, obj, icv_length, MLX5_IPSEC_OBJECT_ICV_LEN_16B);
salt_iv_p = MLX5_ADDR_OF(ipsec_obj, obj, implicit_iv);
memcpy(salt_iv_p, &aes_gcm->seq_iv, sizeof(aes_gcm->seq_iv));
/* esn */
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index 7d2d0ba82144..1fa4ade54c76 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -11383,8 +11383,6 @@ enum {
enum {
MLX5_IPSEC_OBJECT_ICV_LEN_16B,
- MLX5_IPSEC_OBJECT_ICV_LEN_12B,
- MLX5_IPSEC_OBJECT_ICV_LEN_8B,
};
struct mlx5_ifc_ipsec_obj_bits {
--
2.35.1
next prev parent reply other threads:[~2022-04-10 8:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 8:28 [PATCH mlx5-next 00/17] Extra IPsec cleanup Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 01/17] net/mlx5: Simplify IPsec flow steering init/cleanup functions Leon Romanovsky
2022-04-10 16:46 ` Saeed Mahameed
2022-04-10 17:21 ` Leon Romanovsky
2022-04-10 21:58 ` Saeed Mahameed
2022-04-11 6:37 ` Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 02/17] net/mlx5: Check IPsec TX flow steering namespace in advance Leon Romanovsky
2022-04-10 23:46 ` Saeed Mahameed
2022-04-11 6:21 ` Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 03/17] net/mlx5: Don't hide fallback to software IPsec in FS code Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 04/17] net/mlx5: Reduce useless indirection in IPsec FS add/delete flows Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 05/17] net/mlx5: Store IPsec ESN update work in XFRM state Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 06/17] net/mlx5: Remove useless validity check Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 07/17] net/mlx5: Merge various control path IPsec headers into one file Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 08/17] net/mlx5: Remove accel notations and indirections from esp functions Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 09/17] net/mlx5: Simplify HW context interfaces by using SA entry Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 10/17] net/mlx5: Clean IPsec FS add/delete rules Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 11/17] net/mlx5: Make sure that no dangling IPsec FS pointers exist Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 12/17] net/mlx5: Don't advertise IPsec netdev support for non-IPsec device Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 13/17] net/mlx5: Simplify IPsec capabilities logic Leon Romanovsky
2022-04-10 8:28 ` Leon Romanovsky [this message]
2022-04-10 8:28 ` [PATCH mlx5-next 15/17] net/mlx5: Cleanup XFRM attributes struct Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 16/17] net/mlx5: Allow future addition of IPsec object modifiers Leon Romanovsky
2022-04-10 8:28 ` [PATCH mlx5-next 17/17] net/mlx5: Don't perform lookup after already known sec_path Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8103cc94fc14d1ee72b50065dec3bf98856f0f.1649578827.git.leonro@nvidia.com \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox