From: liweihang <liweihang@huawei.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"leon@kernel.org" <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: Re: [PATCH v2 for-next] RDMA/hns: Adjust definition of FRMR fields
Date: Wed, 10 Feb 2021 02:07:07 +0000 [thread overview]
Message-ID: <4e7852507f9c499e87f861b42fe6c8c8@huawei.com> (raw)
In-Reply-To: 20210209171247.GP4247@nvidia.com
On 2021/2/10 1:13, Jason Gunthorpe wrote:
> On Tue, Feb 09, 2021 at 04:38:43PM +0800, Weihang Li wrote:
>> @@ -545,7 +545,10 @@ static int set_rc_opcode(struct hns_roce_v2_rc_send_wqe *rc_sq_wqe,
>> rc_sq_wqe->va = cpu_to_le64(atomic_wr(wr)->remote_addr);
>> break;
>> case IB_WR_REG_MR:
>> - set_frmr_seg(rc_sq_wqe, reg_wr(wr));
>> + if (hr_dev->pci_dev->revision >= PCI_REVISION_ID_HIP09)
>> + set_frmr_seg(rc_sq_wqe, reg_wr(wr));
>> + else
>> + ret = -EOPNOTSUPP;
>
> The driver must also clear IB_DEVICE_MEM_MGT_EXTENSIONS if it won't
> support IB_WR_REG_MR
>
> Jason
>
Thanks for the reminder, I will fix it.
Weihang
prev parent reply other threads:[~2021-02-10 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 8:38 [PATCH v2 for-next] RDMA/hns: Adjust definition of FRMR fields Weihang Li
2021-02-09 17:12 ` Jason Gunthorpe
2021-02-10 2:07 ` liweihang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7852507f9c499e87f861b42fe6c8c8@huawei.com \
--to=liweihang@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@openeuler.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox