Re: [PATCH 11/20] ib_srp: Make srp_disconnect_target() wait for IB completions

[Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>]

On 08/23/12 15:59, Sebastian Riemer wrote:
> we've triggered the WARN_ON() in srp_wait_last_send_wqe() by connecting
> to a disabled SCST SRP target.
> 
> I would remove that one.
> 
> [ ... ]
>
>> +	while (!target->last_send_wqe && time_before(jiffies, deadline)) {
>> +		srp_send_completion(target->send_cq, target);
>> +		msleep(20);
>> +	}
>> +
>> +	WARN_ON(!target->last_send_wqe);
> 
> <-- here it is - remove it

But why was that WARN_ON() statement hit ? srp_wait_last_send_wqe() is
invoked after the QP has been transitioned into the error state. It is
the responsibility of the HCA to generate an error completion for any
work queued on a QP that is in the error state. If that WARN_ON()
statement has been hit that means that it took more than the RC timeout
before the HCA finished processing earlier queued work and generated an
error completion. That's not really something I had expected.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html