From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org
Cc: dillowda-1Heg1YXhbW8@public.gmane.org,
roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
JBottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/5] ib_srp: hold a mutex when adding a new target port
Date: Sat, 01 Sep 2012 07:55:05 +0000 [thread overview]
Message-ID: <5041BF59.70307@acm.org> (raw)
In-Reply-To: <1346443241-24844-4-git-send-email-dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
On 08/31/12 20:00, dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org wrote:
> ------------[ cut here ]------------
> WARNING: at block/genhd.c:1466 __disk_unblock_events+0x10f/0x120()
> Pid: 17238, comm: scsi_id Not tainted 3.2.8-pserver #1
> Call Trace:
> [<ffffffff81048dbb>] ? warn_slowpath_common+0x7b/0xc0
> [<ffffffff813879bf>] ? __disk_unblock_events+0x10f/0x120
> [<ffffffff81162b30>] ? __blkdev_get+0x190/0x410
> [<ffffffff811630c0>] ? blkdev_get+0x310/0x310
> [<ffffffff81162dfb>] ? blkdev_get+0x4b/0x310
> [<ffffffff811630c0>] ? blkdev_get+0x310/0x310
> [<ffffffff8112d513>] ? __dentry_open+0x263/0x370
> [<ffffffff8113a0fe>] ? path_get+0x1e/0x30
> [<ffffffff8113b4a0>] ? do_last+0x3e0/0x800
> [<ffffffff8113c21b>] ? path_openat+0xdb/0x400
> [<ffffffff8113c66d>] ? do_filp_open+0x4d/0xc0
> [<ffffffff81148c13>] ? alloc_fd+0x43/0x130
> [<ffffffff8112d915>] ? do_sys_open+0x105/0x1e0
> [<ffffffff8165d512>] ? system_call_fastpath+0x16/0x1b
> ---[ end trace 4edc2747f936431c ]---
That's the "if (WARN_ON_ONCE(ev->block <= 0))" in kernel version 3.2
that you hit, isn't it ? That's not caused by ib_srp but by a race in
the genhd layer. Please have a look at commit 9f53d2fe ("block: fix
__blkdev_get and add_disk race condition").
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-01 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 20:00 [PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes dongsu.park-EIkl63zCoXaH+58JC4qpiA
2012-08-31 20:00 ` [PATCH 1/5] ib_srp: free memory correctly in srp_free_iu() dongsu.park
[not found] ` <1346443241-24844-2-git-send-email-dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2012-09-01 7:32 ` Bart Van Assche
2012-08-31 20:00 ` [PATCH 2/5] ib_srp: removed superfluous warning in send timeout case dongsu.park
[not found] ` <1346443241-24844-3-git-send-email-dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2012-09-01 7:44 ` Bart Van Assche
2012-08-31 20:00 ` [PATCH 3/5] ib_srp: hold a mutex when adding a new target port dongsu.park
[not found] ` <1346443241-24844-4-git-send-email-dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2012-09-01 7:55 ` Bart Van Assche [this message]
2012-08-31 20:00 ` [PATCH 4/5] ib_srp: check if rport->lld_data is NULL before removing rport dongsu.park
[not found] ` <1346443241-24844-5-git-send-email-dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2012-09-01 7:59 ` Bart Van Assche
[not found] ` <1346443241-24844-1-git-send-email-dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2012-08-31 20:00 ` [PATCH 5/5] ib_srp: fix an error accessing invalid memory in rport_dev_loss_timedout dongsu.park-EIkl63zCoXaH+58JC4qpiA
2012-09-01 8:09 ` [PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5041BF59.70307@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=JBottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=dillowda-1Heg1YXhbW8@public.gmane.org \
--cc=dongsu.park-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).