On 9/11/2012 3:07 PM, Roland Dreier wrote: > On Tue, Sep 11, 2012 at 10:12 AM, Doug Ledford wrote: >> As a second note, I would like to know why Intel (previously QLogic) >> does not use these functions in their driver and what it would take to >> get all drivers to use the functions. Do we need to add more to them? >> In my opinion these should be generally useful and used by all drivers. > > Use which functions? The P_Key lookup functions? > > What would a low-level driver use them for? I thought these are for > use by upper-level protocols. Well, at this point, the mlx4 driver uses them, the rdmacm kernel driver uses them, and both QLogic/Intel drivers have their own internal pkey table implementation. So, it isn't so much upper layer as it is drivers. -- Doug Ledford GPG KeyID: 0E572FDD http://people.redhat.com/dledford Infiniband specific RPMs available at http://people.redhat.com/dledford/Infiniband