From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: Problem running rping over Intel adapters Date: Wed, 03 Oct 2012 20:47:45 -0500 Message-ID: <506CEAC1.9070808@opengridcomputing.com> References: <506CB0E9.90201@redhat.com> <1828884A29C6694DAF28B7E6B8A8237346A98E58@FMSMSX151.amr.corp.intel.com> <506CB4D8.4010604@redhat.com> <1828884A29C6694DAF28B7E6B8A8237346A98E8E@FMSMSX151.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237346A98E8E-Q3cL8pyY+6ukrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: Doug Ledford , "Marciniszyn, Mike" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 10/3/2012 5:02 PM, Hefty, Sean wrote: >>>> 1) rping, on the client side, clears the conn_params for the newly to be >>>> attempted connection, then sets: >>>> >>>> conn_param.responder_resources = 1; >>>> conn_param.initiator_depth = 1; >>>> conn_param.retry_count = 10; >>> >>>> 2) the qib driver enforces a maximum of 7 for retry_count. I don't see >>>> anything in the spec that specifies a maximum for this entry, and in >>>> particular I know it doesn't call out for 7 to mean infinite retries >>>> like it does for rnr_retry_count. >>> On IB, retry count is a 3-bit value. See the CM REQ message. >>> >>> The kernel rdma cm should probably check for a valid value and reduce it >> accordingly. >> >> Then it's also fair to say that right now rping passes a known invalid >> value and needs fixed ;-) > For IB, but I wasn't sure about iWarp. It doesn't look like it's used there though. > > If not, I'll apply a patch to rping, plus submit a fix for the kernel to validate the value. > -- Not used by iwarp drivers... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html