Re: [PATCH v2 2/2] IB/srp: Avoid endless SCSI error handling loop

[Vu Pham <vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

Bart Van Assche wrote:
> On 12/14/12 17:19, David Dillow wrote:
>> On Fri, 2012-12-14 at 17:12 +0100, Bart Van Assche wrote:
>>> On 12/14/12 16:55, David Dillow wrote:
>>>> This is much more than your original patch that Alex claimed fixed his
>>>> issues; are you not merging two separate issues?
>>>   >
>>>> Also, there's no reason to invoke srp_send_tsk_mgmt() if we're not
>>>> connected or the QP is in error -- for those cases, it makes sense to
>>>> just abort the command directly. Similarly, we should probably be
>>>> checking the status of srp_send_tsk_mgmt() and failing -- or checking
>>>> qp_in_error/connected again and directly aborting if we have problems.
>>>
>>> Thanks for the quick reply. You might have missed Vu's message though.
>>> Vu Pham reported that v1 of this patch did not fix the endless error
>>> handling loop (see e.g.
>>> http://www.mail-archive.com/linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg13713.html).
>>
>> I saw that, but I also saw your message asking if he was sure he was
>> running with your patch, and I never saw a public reply to clarify.
>>
>> I saw a message from him yesterday that running your fixes branch did
>> work, but with no posting of updated patches I assumed that was v1 still
>> -- was he testing v2?
>
> Hello Dave,
>
> There has been some off-list communication too in which Vu explained 
> me that v1 was not sufficient but that v2 did help.
>
> Bart.
>
Hello Dave,
To confirm what Bart said:

V1 did not solve the endless error handling loop
V2 together with this patch "Save and restore host_scribble during error 
handling -
http://www.mail-archive.com/linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg17809.html" 
solves the scsi_remove_host hang and endless abort issues.

Hi Bart,

With V2, I saw that it took 90-240 seconds for I/Os fail-over (depending 
on the number of outstanding I/Os and the number of paths per physical port)
I'm using default multipath.conf with "dev_loss_tmo 60"  
"fast_io_fail_tmo 10"

Is there way to control/configure the fail-over time?

thanks,
-vu



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html