From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>
Subject: Re: [PATCH v3 0/3] IB/SRP patches for kernel 3.8
Date: Thu, 20 Dec 2012 14:19:24 +0100 [thread overview]
Message-ID: <50D3105C.10005@acm.org> (raw)
In-Reply-To: <50D306DE.7080505-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On 12/20/12 13:38, Or Gerlitz wrote:
> I think few days ago you had a patch on your tree named "Save and
> restore host_scribble during error handling", is it possible we need
> this here for happy removal of the scsi host?
No. Host removal works fine even without that patch. That's because
srp_abort() has been modified such that it finishes a request whether or
not sending a task management function to the target succeeded. As you
can see in scsi_eh_abort_cmnds() if the eh_abort_handler callback
function returns SUCCESS then scsi_eh_test_devices() will be passed an
empty work_q list. Hence the SCSI error handler function
scsi_eh_prep_cmnd() does not get invoked and hence does not have a
chance of overwriting the host_scribble field.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-12-20 13:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 14:20 [PATCH v3 0/3] IB/SRP patches for kernel 3.8 Bart Van Assche
[not found] ` <50D1CD49.5080607-HInyCGIudOg@public.gmane.org>
2012-12-19 14:21 ` [PATCH v3 1/3] IB/srp: Track connection state properly Bart Van Assche
[not found] ` <50D1CD7D.6030905-HInyCGIudOg@public.gmane.org>
2012-12-19 18:04 ` David Dillow
[not found] ` <1355940274.23687.2.camel-zHLflQxYYDO4Hhoo1DtQwJ9G+ZOsUmrO@public.gmane.org>
2012-12-20 8:13 ` Bart Van Assche
[not found] ` <50D2C8C4.3030308-HInyCGIudOg@public.gmane.org>
2012-12-20 15:10 ` David Dillow
[not found] ` <1356016241.2507.1.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2012-12-20 15:24 ` Bart Van Assche
[not found] ` <50D32DC7.9000007-HInyCGIudOg@public.gmane.org>
2012-12-20 15:26 ` [PATCH v4 " Bart Van Assche
2012-12-20 15:27 ` [PATCH v3 " Or Gerlitz
[not found] ` <50D32E7A.4070704-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-12-20 16:27 ` David Dillow
[not found] ` <1356020823.8322.0.camel-zHLflQxYYDO4Hhoo1DtQwJ9G+ZOsUmrO@public.gmane.org>
2012-12-20 20:06 ` Or Gerlitz
2012-12-19 14:22 ` [PATCH v3 2/3] IB/srp: Avoid sending a task management function needlessly Bart Van Assche
[not found] ` <50D1CDB4.9070906-HInyCGIudOg@public.gmane.org>
2012-12-19 18:05 ` David Dillow
2012-12-19 14:24 ` [PATCH v3 3/3] IB/srp: Avoid endless SCSI error handling loop Bart Van Assche
[not found] ` <50D1CE0B.2080902-HInyCGIudOg@public.gmane.org>
2012-12-19 18:07 ` David Dillow
2012-12-20 12:38 ` [PATCH v3 0/3] IB/SRP patches for kernel 3.8 Or Gerlitz
[not found] ` <50D306DE.7080505-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-12-20 13:19 ` Bart Van Assche [this message]
[not found] ` <50D3105C.10005-HInyCGIudOg@public.gmane.org>
2012-12-20 14:56 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D3105C.10005@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).