From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: bug in ucma_accept()? Date: Mon, 07 Jan 2013 13:30:18 -0600 Message-ID: <50EB224A.9020709@opengridcomputing.com> References: <50EB1E49.7020807@opengridcomputing.com> <1828884A29C6694DAF28B7E6B8A8237346AEE645@ORSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237346AEE645-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 1/7/2013 1:22 PM, Hefty, Sean wrote: > >> Is this a bug? I think it is... >> >> diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c >> index 2709ff5..fb24f05 100644 >> --- a/drivers/infiniband/core/ucma.c >> +++ b/drivers/infiniband/core/ucma.c >> @@ -806,8 +806,13 @@ static ssize_t ucma_accept(struct ucma_file *file, >> const ch >> if (!ret) >> ctx->uid = cmd.uid; >> mutex_unlock(&file->mut); >> - } else >> + } else { >> + mutex_lock(&file->mut); >> ret = rdma_accept(ctx->cm_id, NULL); >> + if (!ret) >> + ctx->uid = cmd.uid; >> + mutex_unlock(&file->mut); >> + } > The ctx->uid has already been set in the else case when the user explicitly created the cm_id. We only need to set it when the ctx has been created in the kernel for the user in response to a connection request (the 'if' part to the above else). > > Ah. Thanks for clarifying... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html