Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

[Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 07/02/2013 11:05, Bart Van Assche wrote:
> On 02/06/13 22:42, Vu Pham wrote:
>> Conclusion:
>> 1. disable the port/path long enough >35 minutes, we have dangling scsi
>> host.
>> 2. enable the port within 30 minute, scsi host re-establish connection,
>> path re-instate and then scsi_host was removed (no entry in sysfs)
>>
>> I attached a log here to show what happened above.
>
> Hello Vu,
>
> I found the following in the attached logs:
>
> [ ... ]
> Feb  6 19:24:25 vsa30 kernel: scsi host10: ib_srp: SRP reset_host called
> [ ... ]
> Feb  6 19:25:28 vsa30 kernel: scsi host10: SRP abort called
> [ ... ]
>
> It is easy to see in patch 3/3 that srp_reset_host() invokes 
> srp_reconnect_target() unconditionally and that that last function 
> kills all outstanding requests via srp_reset_req(). So to me the above 
> output means that the attached logs were generated by a kernel missing 
> at least patch 3/3. This means that the above conclusions are invalid.

Hi Bart,

Please calm down, we truly think your work is great step in the right 
direction. We will double check the environment and the logs provided to 
you.
On the half side of the glass, I think Vu also saw things that work 
better with these patches (BTW - if the fourth patch that Vu used "save 
& restore host_scribble during error handling" is also needed, maybe you 
add  it to this series, so they are reviewed/accepted together).

We will set with you online session in the coming 2-3 working days to 
build the kernel and conduct the test together.

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html