From: Allison Henderson <achender@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
pabeni@redhat.com, edumazet@google.com, horms@kernel.org,
jhubbard@nvidia.com, woni9911@gmail.com,
michal.kubiak@intel.com, leon@kernel.org
Subject: Re: [PATCH net-next v2 0/5] net/rds: own the fastpath locks across connection teardown
Date: Fri, 21 Aug 2026 22:33:46 -0700 [thread overview]
Message-ID: <511c157524504bfe5d53fd739538ccbd0ebba7d4.camel@kernel.org> (raw)
In-Reply-To: <20260821170347.77cfaadd@kernel.org>
On Fri, 2026-08-21 at 17:03 -0700, Jakub Kicinski wrote:
> On Thu, 20 Aug 2026 22:07:26 -0700 Allison Henderson wrote:
> > The other commentary nits from the review do have merit though. If you
> > like, I can send a v3 with those corrected, but I think the code itself
> > is ok. The patch 1 comment about cong.c is a pre-existing issue similar
> > to the lost-wakeup issue that patch 1 fixes. So I can send a follow-up
> > converting those waitqueue_active() calls to wq_has_sleeper().
> >
> > I hope that helps? Thank you for being accommodating with the branch
> > targeting.
>
> Thanks, yes! IIUC you don't mind sending a v3 so let's go with that
> option.
You're welcome, I've sent out an updated v3 and one extra patch for cong.c.
Thanks!
Allison
prev parent reply other threads:[~2026-08-22 5:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 0:15 [PATCH net-next v2 0/5] net/rds: own the fastpath locks across connection teardown Allison Henderson
2026-08-16 0:15 ` [PATCH net-next v2 1/5] net/rds: use wq_has_sleeper() in release_in_xmit() Allison Henderson
2026-08-16 0:15 ` [PATCH net-next v2 2/5] net/rds: clear cp_flags bits individually in rds_conn_path_reset() Allison Henderson
2026-08-16 0:15 ` [PATCH net-next v2 3/5] net/rds: tcp: don't force RDS_CONN_RESETTING over a concurrent shutdown Allison Henderson
2026-08-16 0:15 ` [PATCH net-next v2 4/5] net/rds: acquire RDS_IN_XMIT in rds_tcp_reset_callbacks() Allison Henderson
2026-08-16 0:15 ` [PATCH net-next v2 5/5] net/rds: acquire the fastpath locks in rds_conn_shutdown() Allison Henderson
2026-08-20 20:38 ` [PATCH net-next v2 0/5] net/rds: own the fastpath locks across connection teardown Jakub Kicinski
2026-08-21 5:07 ` Allison Henderson
2026-08-22 0:03 ` Jakub Kicinski
2026-08-22 5:33 ` Allison Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511c157524504bfe5d53fd739538ccbd0ebba7d4.camel@kernel.org \
--to=achender@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=woni9911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox