From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 1/7] libibumad: Provide MAD definitions with libibumad
Date: Wed, 20 Feb 2013 14:15:27 -0500 [thread overview]
Message-ID: <512520CF.8000902@dev.mellanox.co.il> (raw)
In-Reply-To: <5124FC59.2070602-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On 2/20/2013 11:39 AM, Hal Rosenstock wrote:
> On 2/20/2013 11:29 AM, Hefty, Sean wrote:
>>> I need to check the kernel code, but I believe that the RMPP header is exposed.
>>
>> I looked at copy_recv_mad(), and it copies the entire 256-byte MAD to user space, which includes any RMPP header, followed by any additional segmented data. So most of the RMPP definitions are relevant, the exceptions possibly being UMAD_RMPP_TYPE_[ACK | STOP | ABORT]. IMO - I would keep those for completeness.
>
> Yes but how much of header is relevant when it's a multipacket RMPP MAD
> message ? My concern is that it may be confusing as to validity/use of
> certain RMPP fields, etc.
How about moving ahead without these for now ? They can always be added
back in when the time is right. If that's acceptable to you, I'll make
that modification myself and move onto the other libibumad patches in
your series.
-- Hal
>
> -- Hal
>
>> - Sean
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-02-20 19:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 21:38 [PATCH 1/7] libibumad: Provide MAD definitions with libibumad sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1359409135-559-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-28 21:38 ` [PATCH 2/7] libibumad: Add SA MAD definitions to umad sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1359409135-559-2-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-20 22:40 ` Hal Rosenstock
2013-01-28 21:38 ` [PATCH 3/7] libibumad: Add basic SM " sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1359409135-559-3-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-20 22:40 ` Hal Rosenstock
2013-01-28 21:38 ` [PATCH 4/7] libibumad: Add CM " sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1359409135-559-4-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-20 22:40 ` Hal Rosenstock
2013-01-28 21:38 ` [PATCH 5/7] libibumad: Add new umad header files to release sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1359409135-559-5-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-20 22:40 ` Hal Rosenstock
2013-01-28 21:38 ` [PATCH 6/7] libibumad: Define ntohll/htonll sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1359409135-559-6-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-20 22:40 ` Hal Rosenstock
2013-01-28 21:38 ` [PATCH 7/7] libibumad: Define data type to indicate values are in big-endian sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1359409135-559-7-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-21 16:03 ` Hal Rosenstock
2013-02-20 15:56 ` [PATCH 1/7] libibumad: Provide MAD definitions with libibumad Hal Rosenstock
[not found] ` <5124F212.2060503-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-02-20 16:07 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823736F34E958-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-02-20 16:29 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823736F34E976-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-02-20 16:39 ` Hal Rosenstock
[not found] ` <5124FC59.2070602-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-02-20 17:42 ` Ira Weiny
[not found] ` <20130220094219.19f80f5c0b65c50a48b29c96-i2BcT+NCU+M@public.gmane.org>
2013-02-20 19:12 ` Hal Rosenstock
2013-02-20 19:15 ` Hal Rosenstock [this message]
[not found] ` <512520CF.8000902-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-02-20 21:06 ` Hefty, Sean
2013-02-20 22:39 ` Hal Rosenstock
-- strict thread matches above, loose matches on Subject: below --
2011-04-28 22:57 [PATCH 1/7] libibumad: provide " Hefty, Sean
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF261A1F410B-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-05-02 13:20 ` Alex Netes
[not found] ` <20110502132013.GE2088-iQai9MGU/dyyaiaB+Ve85laTQe2KTcn/@public.gmane.org>
2011-05-02 17:52 ` Hefty, Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512520CF.8000902@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox