Re: [PATCH] libibumad: add string functions for various enums

[Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 3/1/2013 8:56 PM, Ira Weiny wrote:
> Resend to the list.  My phone apparently sends html which was rejected.
> 
> On Fri, Mar 1, 2013 at 5:51 PM, Ira Weiny <iweiny-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Never mind. I was thinking the check for busy and redirect were "==" not a
>> mask.
>>
>> Sorry many things going on today.
>>
>> So I think we are good then?

If this is referring to reserved values in the Code for invalid field in
the status field (and not a reserved field), then yes, we're good.

-- Hal

>>
>> Ira
>>
>>
>>
>> "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>>>
>>>> If those reserve fields are either A) not correctly set to 0 or B) are
>>>> used for
>>>>
>>>> some future status this function will fail.  Since the spec says to
>>>> ignore them
>>>> I would do something like.
>>>>
>>>>  status = ntohs(status);
>>>>  status &= 0x001F;
>>>>
>>>> With a #define'd mask for 1F of course...  ;-)
>>>
>>>
>>> Your proposed implementation already ignores those bits.  I'm confused.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>> --
>> www.lightcipher.com
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html