From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "linux-rdma
(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] opensm/osm_subnet.c: Miscellaneous minor fixes
Date: Thu, 07 Mar 2013 09:10:39 -0500 [thread overview]
Message-ID: <51389FDF.80608@dev.mellanox.co.il> (raw)
Use strdup in a couple of places where strings were copied
Also, fix log message
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index 61a7cc3..f585a42 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -1497,7 +1497,7 @@ void osm_subn_set_default_opt(IN osm_subn_opt_t * p_opt)
p_opt->dump_files_dir = getenv("OSM_TMP_DIR");
if (!p_opt->dump_files_dir || !(*p_opt->dump_files_dir))
- p_opt->dump_files_dir = OSM_DEFAULT_TMP_DIR;
+ p_opt->dump_files_dir = strdup(OSM_DEFAULT_TMP_DIR);
p_opt->dump_files_dir = strdup(p_opt->dump_files_dir);
p_opt->log_file = strdup(OSM_DEFAULT_LOG_FILE);
p_opt->log_max_size = 0;
@@ -1987,8 +1987,8 @@ int osm_subn_verify_config(IN osm_subn_opt_t * p_opts)
else {
log_report(" Invalid Cached Option Value:part_enforce = %s"
", Using Default:%s\n",
- p_opts->part_enforce = OSM_PARTITION_ENFORCE_BOTH);
- p_opts->part_enforce = OSM_PARTITION_ENFORCE_BOTH;
+ p_opts->part_enforce, OSM_PARTITION_ENFORCE_BOTH);
+ strcpy(p_opts->part_enforce, OSM_PARTITION_ENFORCE_BOTH);
p_opts->part_enforce_enum = OSM_PARTITION_ENFORCE_TYPE_BOTH;
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2013-03-07 14:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51389FDF.80608@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox