Re: [PATCH] opensm: Fix issues causing const warnings for strings

[Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 3/12/2013 10:12 AM, Weiny, Ira wrote:
>> -----Original Message-----
>> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
>> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Hal Rosenstock
>> Sent: Tuesday, March 12, 2013 9:45 AM
>> To: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
>> Subject: [PATCH] opensm: Fix issues causing const warnings for strings
>>
>>
>> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> ---
> 
> [snip]
> 
>>
>> diff --git a/opensm/main.c b/opensm/main.c index 1a061a8..db5429a 100644
>> --- a/opensm/main.c
>> +++ b/opensm/main.c
>> @@ -718,7 +718,7 @@ int main(int argc, char *argv[])
>>  	optind = 0;		/* reset command line */
>>
>>  	if (!config_file)
>> -		config_file = OSM_DEFAULT_CONFIG_FILE;
>> +		config_file = strdup(OSM_DEFAULT_CONFIG_FILE);
>>
> 
> Why is the strdup here but not on the optarg above?
> 
> Also, is this free'ed anywhere?  Can the config file change at run time?  I don't think it can but perhaps you are moving that direction?
> 
> Also, perhaps the strdup should be within osm_subn_parse_conf_file?  

Version 2 patch to follow shortly.

-- Hal

> 
> Ira
> 
> [snip]
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html