[PATCH] libibmad: To handle null dev_name in madrpc_init

[PATCH] libibmad: To handle null dev_name in madrpc_init

[Boris Chiu]

From: Brendan Doyle <brendan.doyle-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

Signed-off-by: Brendan Doyle <brendan.doyle-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 src/rpc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/rpc.c b/src/rpc.c
index 6312d42..cb224fd 100644
--- a/src/rpc.c
+++ b/src/rpc.c
@@ -360,7 +360,8 @@ madrpc_init(char *dev_name, int dev_port, int *mgmt_classes, int num_classes)
 		IBPANIC("can't init UMAD library");
 
 	if ((fd = umad_open_port(dev_name, dev_port)) < 0)
-		IBPANIC("can't open UMAD port (%s:%d)", dev_name, dev_port);
+		IBPANIC("can't open UMAD port (%s:%d)",
+		dev_name ? dev_name : "(nil)", dev_port);
 
 	if (num_classes >= MAX_CLASS)
 		IBPANIC("too many classes %d requested", num_classes);
-- 
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibmad: To handle null dev_name in madrpc_init

[Ira Weiny]

On Tue, Mar 12, 2013 at 12:38 PM, Boris Chiu <boris.chiu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> From: Brendan Doyle <brendan.doyle-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> Signed-off-by: Brendan Doyle <brendan.doyle-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

Thanks applied,
Ira

> ---
> src/rpc.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/rpc.c b/src/rpc.c
> index 6312d42..cb224fd 100644
> --- a/src/rpc.c
> +++ b/src/rpc.c
> @@ -360,7 +360,8 @@ madrpc_init(char *dev_name, int dev_port, int
> *mgmt_classes, int num_classes)
>                 IBPANIC("can't init UMAD library");
>
>         if ((fd = umad_open_port(dev_name, dev_port)) < 0)
> -               IBPANIC("can't open UMAD port (%s:%d)", dev_name, dev_port);
> +               IBPANIC("can't open UMAD port (%s:%d)",
> +               dev_name ? dev_name : "(nil)", dev_port);
>
>         if (num_classes >= MAX_CLASS)
>                 IBPANIC("too many classes %d requested", num_classes);
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html